refactor: reorder initializations in app.go #2017
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cgorenflo
requested review from
jcs47,
haiyizxx,
milapsheth and
cjcobb23
as code owners
cgorenflo
force-pushed
the
reorder-initializations
branch
from
746f2ff to
ac5dbfd
Compare
cgorenflo
force-pushed
the
extract-init-keeper
branch
from
efd1fb4 to
27a2163
Compare
cgorenflo
force-pushed
the
reorder-initializations
branch
from
ac5dbfd to
19cb029
Compare
haiyizxx
approved these changes
Nov 6, 2023
This commit refactors the keeper initialization logic in the Axelar application. Now, each keeper is initialized in a separate function within the app package, which improves code readability and maintainability.
cgorenflo
force-pushed
the
extract-init-keeper
branch
from
27a2163 to
16d5bc9
Compare
This change reorders initializations in app.go, so they are better grouped and closer to where they are needed
cgorenflo
force-pushed
the
reorder-initializations
branch
from
19cb029 to
94ee852
Compare
fish-sammy
approved these changes
Nov 6, 2023
# Conflicts: # app/app.go # app/keepers.go
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.