fix: nexus message router get correctly set up #2031
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because keepers were passed as values instead of references, some modules, which relied on the nexus keeper and were initialized before the nexus message router was set up, couldn't use the correct nexus routing. By passing the nexus router as a reference, later router set up still affects the initialized keepers now.
fish-sammy
reviewed
Nov 20, 2023
fish-sammy
reviewed
Nov 20, 2023
cjcobb23
reviewed
Nov 21, 2023
# Conflicts: # app/app.go # app/keepers.go
fish-sammy
approved these changes
Nov 28, 2023
fish-sammy
approved these changes
Nov 28, 2023
cjcobb23
approved these changes
Nov 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because keepers were passed as values instead of references, some modules, which relied on the nexus keeper and were initialized before the nexus message router was set up, couldn't use the correct nexus routing. By passing the nexus router as a reference, later router set up still affects the initialized keepers now.
AXE-2640