Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(nexus)!: expose IsChainRegistered query to wasm #2182

Merged
merged 5 commits into from
Sep 25, 2024

Conversation

haiyizxx
Copy link
Contributor

Description

Todos

  • Unit tests
  • Manual tests
  • Documentation
  • Connect epics/issues
  • Tag type of change
  • Upgrade handler

Steps to Test

Expected Behaviour

Other Notes

Copy link

codecov bot commented Sep 16, 2024

Codecov Report

Attention: Patch coverage is 11.76471% with 15 lines in your changes missing coverage. Please review.

Project coverage is 49.41%. Comparing base (b81c103) to head (b21fe20).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
x/nexus/keeper/wasm_querier.go 0.00% 15 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2182      +/-   ##
==========================================
- Coverage   49.47%   49.41%   -0.06%     
==========================================
  Files         272      272              
  Lines       16141    16151      +10     
==========================================
- Hits         7985     7981       -4     
- Misses       7544     7558      +14     
  Partials      612      612              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@haiyizxx haiyizxx force-pushed the AXE-4867-Expose-chain-name-query-to-amplifier branch from 46c4972 to 5b18e88 Compare September 16, 2024 22:12
@haiyizxx haiyizxx marked this pull request as ready for review September 16, 2024 22:12
@haiyizxx haiyizxx requested a review from a team as a code owner September 16, 2024 22:12
x/nexus/exported/types.go Outdated Show resolved Hide resolved
x/nexus/exported/types.go Outdated Show resolved Hide resolved
x/nexus/keeper/wasm_querier.go Show resolved Hide resolved
@haiyizxx haiyizxx merged commit 22f2de7 into main Sep 25, 2024
6 of 7 checks passed
@haiyizxx haiyizxx deleted the AXE-4867-Expose-chain-name-query-to-amplifier branch September 25, 2024 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants