Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(wasm)!: fix type interface conversion #2192

Merged
merged 7 commits into from
Oct 14, 2024

Conversation

milapsheth
Copy link
Member

@milapsheth milapsheth commented Oct 4, 2024

Description

AXE-5748

Todos

  • Unit tests
  • Manual tests
  • Documentation
  • Connect epics/issues
  • Tag type of change
  • Upgrade handler

Steps to Test

Expected Behaviour

Other Notes

Copy link

codecov bot commented Oct 4, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 39.23%. Comparing base (5d08029) to head (f2cf880).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
x/nexus/keeper/wasmer_engine.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2192      +/-   ##
==========================================
+ Coverage   39.21%   39.23%   +0.01%     
==========================================
  Files         373      373              
  Lines       31731    31733       +2     
==========================================
+ Hits        12444    12451       +7     
+ Misses      18347    18343       -4     
+ Partials      940      939       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@milapsheth milapsheth marked this pull request as ready for review October 7, 2024 15:57
@milapsheth milapsheth requested a review from a team as a code owner October 7, 2024 15:57
@milapsheth milapsheth enabled auto-merge (squash) October 11, 2024 19:36
@milapsheth milapsheth merged commit 22563b8 into main Oct 14, 2024
6 of 7 checks passed
@milapsheth milapsheth deleted the fix/query-interface-conversion branch October 14, 2024 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants