Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(nexus): gmp events metadata (#2189) #2199

Merged
merged 2 commits into from
Oct 18, 2024
Merged

feat(nexus): gmp events metadata (#2189) #2199

merged 2 commits into from
Oct 18, 2024

Conversation

haiyizxx
Copy link
Contributor

Description

Todos

  • Unit tests
  • Manual tests
  • Documentation
  • Connect epics/issues
  • Tag type of change
  • Upgrade handler

Steps to Test

Expected Behaviour

Other Notes

Copy link

codecov bot commented Oct 18, 2024

Codecov Report

Attention: Patch coverage is 91.17647% with 3 lines in your changes missing coverage. Please review.

Project coverage is 39.13%. Comparing base (2a8810a) to head (798132a).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
x/axelarnet/message_handler.go 76.92% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2199      +/-   ##
==========================================
- Coverage   39.16%   39.13%   -0.04%     
==========================================
  Files         373      373              
  Lines       31699    37216    +5517     
==========================================
+ Hits        12414    14563    +2149     
- Misses      18349    21717    +3368     
  Partials      936      936              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@haiyizxx haiyizxx marked this pull request as ready for review October 18, 2024 09:31
@haiyizxx haiyizxx requested a review from a team as a code owner October 18, 2024 09:31
Copy link
Member

@kyanokashi kyanokashi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to just sort out dependencies

@milapsheth milapsheth merged commit fad8abd into main Oct 18, 2024
8 of 9 checks passed
@milapsheth milapsheth deleted the cherry-pick-2189 branch October 18, 2024 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants