Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(app)!: migrate pre-initialized module accounts #2206

Merged
merged 2 commits into from
Nov 12, 2024

Conversation

haiyizxx
Copy link
Contributor

@haiyizxx haiyizxx commented Nov 5, 2024

Description

Todos

  • Unit tests
  • Manual tests
  • Documentation
  • Connect epics/issues
  • Tag type of change
  • Upgrade handler

Steps to Test

Expected Behaviour

Other Notes

Copy link

codecov bot commented Nov 5, 2024

Codecov Report

Attention: Patch coverage is 64.15094% with 19 lines in your changes missing coverage. Please review.

Please upload report for BASE (main@8fa58f2). Learn more about missing BASE report.
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
app/migrate_module_account.go 70.83% 11 Missing and 3 partials ⚠️
app/app.go 0.00% 5 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2206   +/-   ##
=======================================
  Coverage        ?   39.36%           
=======================================
  Files           ?      375           
  Lines           ?    37415           
  Branches        ?        0           
=======================================
  Hits            ?    14727           
  Misses          ?    21740           
  Partials        ?      948           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@haiyizxx haiyizxx force-pushed the AXE-4855-Pre-initialize-blocked-core-module-accounts branch from 1ab2c43 to 28bb148 Compare November 6, 2024 16:43
@haiyizxx haiyizxx marked this pull request as ready for review November 6, 2024 16:43
@haiyizxx haiyizxx requested a review from a team as a code owner November 6, 2024 16:43
@haiyizxx haiyizxx added the next release Required for the next release label Nov 6, 2024
app/migrate_module_account.go Show resolved Hide resolved
app/migrate_module_account.go Show resolved Hide resolved
app/app.go Show resolved Hide resolved
@haiyizxx haiyizxx merged commit 81d4315 into main Nov 12, 2024
8 of 9 checks passed
@haiyizxx haiyizxx deleted the AXE-4855-Pre-initialize-blocked-core-module-accounts branch November 12, 2024 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
next release Required for the next release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants