Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore/stellar node mac #1280

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Chore/stellar node mac #1280

wants to merge 7 commits into from

Conversation

benjamin852
Copy link
Contributor

No description provided.

Copy link

vercel bot commented Jan 2, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
axelar-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 13, 2025 4:08pm

Copy link
Contributor

@apolikamixitos apolikamixitos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@benjamin852 If you could also add a "Call out" that highlights that these instructions are for specific versions of Stellar and Soroban, so in case the Stellar team decides to do some refactoring or changes that might break these instructions.

src/content/docs/validator/external-chains/soroban.mdx Outdated Show resolved Hide resolved
@apolikamixitos
Copy link
Contributor

@benjamin852 there are still some *soroban* occurrences happening in the documentation, if you could address them that would be great (ex: with stellar-rpc on https://github.com/stellar/stellar-rpc/blob/c7e9737b54913f5a33f29decdb0c9f6101dc1cfc/Makefile#L94).

also, Soroban is still shown on the sidebar, could you please rename the file to stellar.mdx?

Screenshot 2025-01-07 at 10 50 03 AM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants