consortium: fix not validated snapshot query #397
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `verifyFinalitySignatures` function is invoked in `VerifyHeaderAndParents` before the condition `parent.Number.Uint64() == number-1 && parent.Hash() == header.ParentHash` is checked. This can result in generating and storing an invalid snapshot because the block number and block hash provided as inputs for `snapshot` do not match. If the `if number == c.forkedBlock-1` block is executed, this can lead to overwriting past snapshot with invalid data.
andicrypt
reviewed
Jan 16, 2024
minh-bq
approved these changes
Jan 23, 2024
Francesco4203
pushed a commit
to Francesco4203/ronin
that referenced
this pull request
Jun 18, 2024
The `verifyFinalitySignatures` function is invoked in `VerifyHeaderAndParents` before the condition `parent.Number.Uint64() == number-1 && parent.Hash() == header.ParentHash` is checked. This can result in generating and storing an invalid snapshot because the block number and block hash provided as inputs for `snapshot` do not match. If the `if number == c.forkedBlock-1` block is executed, this can lead to overwriting past snapshot with invalid data.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
verifyFinalitySignaturesfunction is invoked inVerifyHeaderAndParentsbefore the conditionparent.Number.Uint64() == number-1 && parent.Hash() == header.ParentHashis checked. This can result in generating and storing an invalid snapshot because the block number and block hash provided as inputs forsnapshotdo not match. If theif number == c.forkedBlock-1block is executed, this can lead to overwriting past snapshot with invalid data.