docs: Fix incorrect option name #1695
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The option is actually called `install-success-msg`; using `custom-success-msg` does not work.
ashleygwilliams
approved these changes
Jan 15, 2025
|
thank you so much for this and apologies for the misleading docs/confusion! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The option is actually called
install-success-msg; usingcustom-success-msgdoes not work.Unrelated thing I noticed while testing this option: Backticks inside that message actually behave as shell backticks. Not sure if intentional or not (can't think of any reason why someone would want this). Maybe that deserves a warning so people are not surprised by it, or to be fixed so the message can contain anything w/o being interpreted by the shell?