Skip to content

Fail early if required tools can't be found. #4643

Fail early if required tools can't be found.

Fail early if required tools can't be found. #4643

GitHub Actions / clippy failed Dec 16, 2024 in 0s

clippy

9 errors

Details

Results

Message level Amount
Internal compiler error 0
Error 9
Warning 0
Note 0
Help 0

Versions

  • rustc 1.79.0 (129f3b996 2024-06-10)
  • cargo 1.79.0 (ffa9cf99a 2024-06-03)
  • clippy 0.1.79 (129f3b9 2024-06-10)

Annotations

Check failure on line 70 in cargo-dist/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

variable does not need to be mutable

error: variable does not need to be mutable
  --> cargo-dist/src/lib.rs:70:9
   |
70 |     let mut need_zigbuild = false;
   |         ----^^^^^^^^^^^^^
   |         |
   |         help: remove this `mut`

Check failure on line 69 in cargo-dist/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

variable does not need to be mutable

error: variable does not need to be mutable
  --> cargo-dist/src/lib.rs:69:9
   |
69 |     let mut need_xwin = false;
   |         ----^^^^^^^^^
   |         |
   |         help: remove this `mut`

Check failure on line 62 in cargo-dist/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

variable does not need to be mutable

error: variable does not need to be mutable
  --> cargo-dist/src/lib.rs:62:16
   |
62 |     let (dist, mut manifest) = tasks::gather_work(cfg)?;
   |                ----^^^^^^^^
   |                |
   |                help: remove this `mut`
   |
   = note: `-D unused-mut` implied by `-D warnings`
   = help: to override `-D warnings` add `#[allow(unused_mut)]`

Check failure on line 62 in cargo-dist/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

unused variable: `manifest`

error: unused variable: `manifest`
  --> cargo-dist/src/lib.rs:62:20
   |
62 |     let (dist, mut manifest) = tasks::gather_work(cfg)?;
   |                    ^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_manifest`
   |
   = note: `-D unused-variables` implied by `-D warnings`
   = help: to override `-D warnings` add `#[allow(unused_variables)]`

Check failure on line 70 in cargo-dist/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

variable does not need to be mutable

error: variable does not need to be mutable
  --> cargo-dist/src/lib.rs:70:9
   |
70 |     let mut need_zigbuild = false;
   |         ----^^^^^^^^^^^^^
   |         |
   |         help: remove this `mut`

Check failure on line 69 in cargo-dist/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

variable does not need to be mutable

error: variable does not need to be mutable
  --> cargo-dist/src/lib.rs:69:9
   |
69 |     let mut need_xwin = false;
   |         ----^^^^^^^^^
   |         |
   |         help: remove this `mut`

Check failure on line 62 in cargo-dist/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

variable does not need to be mutable

error: variable does not need to be mutable
  --> cargo-dist/src/lib.rs:62:16
   |
62 |     let (dist, mut manifest) = tasks::gather_work(cfg)?;
   |                ----^^^^^^^^
   |                |
   |                help: remove this `mut`
   |
   = note: `-D unused-mut` implied by `-D warnings`
   = help: to override `-D warnings` add `#[allow(unused_mut)]`

Check failure on line 62 in cargo-dist/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

unused variable: `manifest`

error: unused variable: `manifest`
  --> cargo-dist/src/lib.rs:62:20
   |
62 |     let (dist, mut manifest) = tasks::gather_work(cfg)?;
   |                    ^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_manifest`
   |
   = note: `-D unused-variables` implied by `-D warnings`
   = help: to override `-D warnings` add `#[allow(unused_variables)]`

Check failure on line 75 in cargo-dist/src/tests/mock.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

missing fields `cargo_auditable`, `cargo_cyclonedx`, `cargo_xwin` and 1 other field in initializer of `tasks::Tools`

error[E0063]: missing fields `cargo_auditable`, `cargo_cyclonedx`, `cargo_xwin` and 1 other field in initializer of `tasks::Tools`
  --> cargo-dist/src/tests/mock.rs:75:5
   |
75 |     Tools {
   |     ^^^^^ missing `cargo_auditable`, `cargo_cyclonedx`, `cargo_xwin` and 1 other field