filterx/expr-function: avoid using GPtrArray in simple functions #432
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bazsi
force-pushed
the
filterx-use-plain-arrays-in-simple-function-args
branch
2 times, most recently
from
a836dd3 to
78368d0
Compare
…mentation Instead of passing the arguments in a GPtrArray, let's use a simple stack allocated array, voiding a 2 mallocs and 2 frees in any simple function invocations. Signed-off-by: Balazs Scheidler <[email protected]>
bazsi
force-pushed
the
filterx-use-plain-arrays-in-simple-function-args
branch
from
78368d0 to
a154b3e
Compare
bshifter
approved these changes
Jan 7, 2025
There was a problem hiding this comment.
This approach seems to work well. If I hadn’t suggested using GPtrArray back then, this probably would have been my initial approach. It’s a straightforward solution, and while I think the performance improvement is minor, it’s still a cleaner and more efficient choice.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of passing the arguments in a GPtrArray, let's use a simple stack allocated array, voiding a 2 mallocs and 2 frees in any simple function invocations.