Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

filterx: optimize followup #436

Merged
merged 23 commits into from
Jan 3, 2025
Merged

filterx: optimize followup #436

merged 23 commits into from
Jan 3, 2025

Conversation

alltilla
Copy link
Member

@alltilla alltilla commented Jan 2, 2025

Followup for #421

alltilla added 15 commits January 2, 2025 15:33
@alltilla
filterx/expr-condition: fix return type
90793d4 
Signed-off-by: Attila Szakacs <[email protected]>
@alltilla
filterx/expr-null-coalesce.c: use optimize() method
247cdaa 
Signed-off-by: Attila Szakacs <[email protected]>
@alltilla
filterx/func-flatten: use optimize() method
5abe726 
Signed-off-by: Attila Szakacs <[email protected]>
@alltilla
filterx/func-istype: use optimize() method
c25ad14 
Signed-off-by: Attila Szakacs <[email protected]>
@alltilla
filterx/func-set-fields: use optimize() method
a6b9cde 
Signed-off-by: Attila Szakacs <[email protected]>
@alltilla
filterx/func-str: use optimize() method
35bb720 
Signed-off-by: Attila Szakacs <[email protected]>
@alltilla
filterx/func-unset-empties: use optimize() method
d49dda8 
Signed-off-by: Attila Szakacs <[email protected]>
@alltilla
csvparser/filterx-func-format-csv: use optimize() method
9edde8d 
Signed-off-by: Attila Szakacs <[email protected]>
@alltilla
filterx/expr-function: add filterx_generator_function_optimize_method()
a6bf4b4 
Signed-off-by: Attila Szakacs <[email protected]>
@alltilla
filterx/expr-function: set default init/deinit/optimize for functions
5e7b66f 
Signed-off-by: Attila Szakacs <[email protected]>
@alltilla
csvparser/filterx-func-parse-csv: use optimize() method
ddd2a07 
Signed-off-by: Attila Szakacs <[email protected]>
@alltilla
kvformat/filterx-func-format-kv: use optimize() method
a6ac752 
Signed-off-by: Attila Szakacs <[email protected]>
@alltilla
kvformat/filterx-func-parse-kv: use optimize() method
9292cba 
Signed-off-by: Attila Szakacs <[email protected]>
@alltilla
xml/filterx-parse-xml: use optimize() method
954d92b 
Signed-off-by: Attila Szakacs <[email protected]>
@alltilla
metrics-probe/filterx/func-update-metric: use optimize() method
b1eb768 
Signed-off-by: Attila Szakacs <[email protected]>
@alltilla alltilla requested review from OverOrion and bazsi January 2, 2025 14:35
OverOrion
OverOrion previously approved these changes Jan 3, 2025
View reviewed changes
Copy link
Contributor

@OverOrion OverOrion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this! 🚀

lib/filterx/expr-null-coalesce.c Outdated Show resolved Hide resolved
@alltilla
cef/event-format-parser: use optimize() method
c1afb73 
Signed-off-by: Attila Szakacs <[email protected]>
@alltilla
cef/event-format-parser: use direct parent's init/deinit
8b0f6f3 
Signed-off-by: Attila Szakacs <[email protected]>
@alltilla
filterx/object-datetime: add missing init and deinit of strftime()
312acc4 
Signed-off-by: Attila Szakacs <[email protected]>
@alltilla
filterx/object-datetime: store format in class
4b2b13f 
Technically it is okay to store just a pointer to
the literal expression's stored value, but this
is a bit cleaner.

Signed-off-by: Attila Szakacs <[email protected]>
@alltilla
filterx/object-datetime: fix copy-paste error
d8a1b86 
Signed-off-by: Attila Szakacs <[email protected]>
@alltilla
filterx/object-datetime: use optimize() method
1f1255b 
Signed-off-by: Attila Szakacs <[email protected]>
@alltilla
filterx/func-keys: use optimize() method
a91a031 
Signed-off-by: Attila Szakacs <[email protected]>
@alltilla
filterx/expr-null-coalesce: refactor to use early return
d746ce7 
Signed-off-by: Attila Szakacs <[email protected]>
@OverOrion OverOrion merged commit a176bdf into axoflow:main Jan 3, 2025
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OverOrion OverOrion OverOrion approved these changes

@bazsi bazsi Awaiting requested review from bazsi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alltilla @OverOrion