filterx/object-message-value: ensure that an extra NUL character is present #438
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…resent Macro based values are captured into an allocated buffer in FilterXMessageValue, but there was no extra NUL character added in case repr_len was specified (which is for any log_msg_get_value() resolutions). This causes valgrind to throw errors when the APPEND_ZERO() macro is used. Signed-off-by: Balazs Scheidler <[email protected]>
bazsi
force-pushed
the
fix-message-value-overflow-for-macro-based-values
branch
from
b310ce9 to
f00094d
Compare
alltilla
approved these changes
Jan 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Macro based values are captured into an allocated buffer in FilterXMessageValue, but there was no extra NUL character added in case repr_len was specified (which is for any log_msg_get_value() resolutions).
This causes valgrind to throw errors when the APPEND_ZERO() macro is used.