-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update aya version to 0.13 #122
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some small nits but overall lgtm
{{project-name}}-ebpf/Cargo.toml
Outdated
@@ -4,7 +4,7 @@ version = "0.1.0" | |||
edition = "2021" | |||
|
|||
[dependencies] | |||
aya-ebpf = "0.1.0" | |||
aya-ebpf = "0.1.1" | |||
aya-log-ebpf = "0.1.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bump to aya-log-ebpf = "0.1.1"
{{project-name}}/src/main.rs
Outdated
@@ -86,14 +86,14 @@ async fn main() -> Result<(), anyhow::Error> { | |||
// like to specify the eBPF program at runtime rather than at compile-time, you can | |||
// reach for `Bpf::load_file` instead. | |||
#[cfg(debug_assertions)] | |||
let mut bpf = Bpf::load(include_bytes_aligned!( | |||
let mut bpf = Ebpf::load(include_bytes_aligned!( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let mut bpf = Ebpf::load(include_bytes_aligned!( | |
let mut ebpf = Ebpf::load(include_bytes_aligned!( |
{{project-name}}/src/main.rs
Outdated
"../../target/bpfel-unknown-none/debug/{{project-name}}" | ||
))?; | ||
#[cfg(not(debug_assertions))] | ||
let mut bpf = Bpf::load(include_bytes_aligned!( | ||
let mut bpf = Ebpf::load(include_bytes_aligned!( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
as above
oh and please squash your commits before we merge this |
Signed-off-by: Xiaobo Liu <[email protected]>
hi @dave-tucker , the above suggestions have been modified, please review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @cppcoffee. LGTM
upgrade aya version to 0.13