Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update aya version to 0.13 #122

Merged
merged 1 commit into from
Oct 10, 2024
Merged

Update aya version to 0.13 #122

merged 1 commit into from
Oct 10, 2024

Conversation

cppcoffee
Copy link
Contributor

upgrade aya version to 0.13

Copy link
Member

@dave-tucker dave-tucker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some small nits but overall lgtm

@@ -4,7 +4,7 @@ version = "0.1.0"
edition = "2021"

[dependencies]
aya-ebpf = "0.1.0"
aya-ebpf = "0.1.1"
aya-log-ebpf = "0.1.0"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bump to aya-log-ebpf = "0.1.1"

@@ -86,14 +86,14 @@ async fn main() -> Result<(), anyhow::Error> {
// like to specify the eBPF program at runtime rather than at compile-time, you can
// reach for `Bpf::load_file` instead.
#[cfg(debug_assertions)]
let mut bpf = Bpf::load(include_bytes_aligned!(
let mut bpf = Ebpf::load(include_bytes_aligned!(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
let mut bpf = Ebpf::load(include_bytes_aligned!(
let mut ebpf = Ebpf::load(include_bytes_aligned!(

"../../target/bpfel-unknown-none/debug/{{project-name}}"
))?;
#[cfg(not(debug_assertions))]
let mut bpf = Bpf::load(include_bytes_aligned!(
let mut bpf = Ebpf::load(include_bytes_aligned!(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as above

@dave-tucker
Copy link
Member

oh and please squash your commits before we merge this

Signed-off-by: Xiaobo Liu <[email protected]>
@cppcoffee cppcoffee changed the title Upgrade aya version Update aya version to 0.13 Oct 10, 2024
@cppcoffee
Copy link
Contributor Author

hi @dave-tucker , the above suggestions have been modified, please review.

Copy link
Member

@dave-tucker dave-tucker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @cppcoffee. LGTM

@dave-tucker dave-tucker merged commit e064758 into aya-rs:main Oct 10, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants