Add cross-compilation to CI #131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tamird
force-pushed
the
cross-compile-mac-os
branch
29 times, most recently
from
bae69c2 to
bf179e9
Compare
tamird
force-pushed
the
cross-compile-mac-os
branch
17 times, most recently
from
c939c72 to
f4d8bdb
Compare
tamird
force-pushed
the
cross-compile-mac-os
branch
4 times, most recently
from
e85a8d7 to
e4bf9b8
Compare
Updates the README to use cargo target config instead of RUSTFLAGS to avoid setting the linker for ebpf in cargo-in-cargo.
tamird
force-pushed
the
cross-compile-mac-os
branch
from
e4bf9b8 to
b336e09
Compare
dave-tucker
approved these changes
Oct 18, 2024
| @@ -3,86 +3,111 @@ | |||
| set -eux | |||
|
|
|||
| TEMPLATE_DIR=$1 | |||
| if [ -z "${TEMPLATE_DIR}" ]; then echo "template dir required"; exit 1; fi | |||
| if [ -z "${TEMPLATE_DIR}" ]; then | |||
There was a problem hiding this comment.
What tool did you use to reformat the shell script?
Perhaps this is something we might consider adding to CI later to ensure changes are consistently formatted
There was a problem hiding this comment.
I just used vscode and didn't investigate what it used under the hood.
| @@ -205,8 +205,9 @@ async fn main() -> anyhow::Result<()> { | |||
| program.attach("{{tracepoint_name}}")?; | |||
| {%- endcase %} | |||
|
|
|||
| let ctrl_c = signal::ctrl_c(); | |||
There was a problem hiding this comment.
Why has this changed? I'm assuming it has something to do with the expect script and how we issue Ctrl+C in the tests?
There was a problem hiding this comment.
I'm not sure it matters, but I realized while debugging things that there was a subtle race here - we were logging "waiting for ..." before actually setting up the signal handler.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the README to use cargo target config instead of RUSTFLAGS to
avoid setting the linker for ebpf in cargo-in-cargo.