Always build eBPF; remove xtask

[tamird]

No description provided.

[vadorovsky]

I think you can fix the current failure by putting

components = ["rust-src"]

into {{project-name}}-ebpf/rust-toolchain.toml

[vadorovsky]

I think you can fix the current failure by putting

components = ["rust-src"]

into {{project-name}}-ebpf/rust-toolchain.toml

nvm, we are installing rust-src in the Github workflow yaml, so that's not the issue. Something more fishy is going in with clippy.

I still think that putting it into rust-toolchain.toml would be good, so people don't have to install rust-src by hand

[tamird]

I think you can fix the current failure by putting

components = ["rust-src"]

into {{project-name}}-ebpf/rust-toolchain.toml

nvm, we are installing rust-src in the Github workflow yaml, so that's not the issue. Something more fishy is going in with clippy.

As always, cargo-in-cargo issue. Should be fixed now.

I still think that putting it into rust-toolchain.toml would be good, so people don't have to install rust-src by hand

Done.

[alessandrod]

why don't we set this in config.toml? It's what I do for my projects

[tamird]

I don't like that as a default. It should be opt in to invoke sudo.

[vadorovsky]

From one hand I find this command quite annoying - the syntax looks really weird.

From the other hand, I do agree that calling sudo should be opt in. Maybe someone wants to use doas or something else.

Only if cargo supported something env var like CARGO_RUNNER, so users could just do export CARGO_RUNNER="sudo -E", which looks less wild.

At the end I think I have a slight preference towards not defaulting.

[tamird]

If there are still concerns with this I'll address them in a follow-up.