Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable unwinding in userspace #134

Merged
merged 4 commits into from
Dec 2, 2024
Merged

Enable unwinding in userspace #134

merged 4 commits into from
Dec 2, 2024

Conversation

tamird
Copy link
Member

@tamird tamird commented Nov 26, 2024

See individual commits.

@tamird tamird force-pushed the config branch 2 times, most recently from 1174a45 to 65f8fa7 Compare November 26, 2024 20:17
Copy link
Member

@vadorovsky vadorovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+ cargo clippy -- --deny warnings
error: 'cargo-clippy' is not installed for the toolchain 'nightly-x86_64-unknown-linux-gnu'.
To install, run `rustup component add --toolchain nightly-x86_64-unknown-linux-gnu clippy`

Perhaps we need to ensure that clippy in installed in the toolchain action.

@tamird
Copy link
Member Author

tamird commented Nov 26, 2024

+ cargo clippy -- --deny warnings
error: 'cargo-clippy' is not installed for the toolchain 'nightly-x86_64-unknown-linux-gnu'.
To install, run `rustup component add --toolchain nightly-x86_64-unknown-linux-gnu clippy`

Perhaps we need to ensure that clippy in installed in the toolchain action.

Ah, it's suddenly respecting the rust-toolchain file.

@tamird tamird force-pushed the config branch 13 times, most recently from ea3b9fc to ebecdff Compare November 26, 2024 22:26
@tamird
Copy link
Member Author

tamird commented Nov 26, 2024

@vadorovsky alright this is finally green.

@tamird tamird force-pushed the config branch 3 times, most recently from 379cd15 to 77d5f5a Compare December 1, 2024 21:41
@vadorovsky vadorovsky merged commit 6580d77 into main Dec 2, 2024
22 checks passed
@vadorovsky vadorovsky deleted the config branch December 2, 2024 05:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants