-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use default-members in Cargo workspace #58
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,2 +1,30 @@ | ||
[alias] | ||
xtask = "run --package xtask --" | ||
xtask = "run --package xtask --" | ||
|
||
# this should migrate to cargo per-target profiles when it is implemented | ||
|
||
[target.bpfel-unknown-none] | ||
rustflags = [ | ||
"-C", "panic=abort", | ||
"-C", "lto=yes", | ||
"-C", "embed-bitcode=yes", | ||
"-C", "debuginfo=2", | ||
"-C", "opt-level=3", | ||
"-C", "codegen-units=1", | ||
"-C", "debug-assertions=no", | ||
"-C", "overflow-checks=no", | ||
"-C", "incremental=no", | ||
] | ||
|
||
[target.bpfeb-unknown-none] | ||
rustflags = [ | ||
"-C", "panic=abort", | ||
"-C", "lto=yes", | ||
"-C", "embed-bitcode=yes", | ||
"-C", "debuginfo=2", | ||
"-C", "opt-level=3", | ||
"-C", "codegen-units=1", | ||
"-C", "debug-assertions=no", | ||
"-C", "overflow-checks=no", | ||
"-C", "incremental=no", | ||
] |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,4 @@ | ||
{ | ||
"rust-analyzer.linkedProjects": ["Cargo.toml", "{{project-name}}-ebpf/Cargo.toml"] | ||
"rust-analyzer.checkOnSave.allTargets": false, | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. why do we need to set this to false? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. because it suppresses a really annoying "cannot find module for |
||
"rust-analyzer.checkOnSave.command": "clippy" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. is this not the default? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,4 @@ | ||
{ | ||
"rust-analyzer.linkedProjects": ["Cargo.toml", "{{project-name}}-ebpf/Cargo.toml"] | ||
"rust-analyzer.checkOnSave.allTargets": false, | ||
"rust-analyzer.checkOnSave.command": "clippy" | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,2 +1,3 @@ | ||
[workspace] | ||
members = ["{{project-name}}", "{{project-name}}-common", "xtask"] | ||
members = ["{{project-name}}", "{{project-name}}-ebpf", "{{project-name}}-common", "xtask"] | ||
default-members = ["{{project-name}}", "{{project-name}}-common", "xtask"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should not turn this on now. It’ll make building slower for no reason