ebpf: Always use release profile
#96
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using `dev` profile, even after tuning flags (to make it identical with `release`) still causes problems and is confusing for people. And even when we have BTF support in future, it'd be better and less confusing to set `debug=2` in `release` profile (because we would want debug info, but still keep the same opt-level and other options).
vadorovsky
force-pushed
the
ebpf-always-release-profile
branch
from
638bbe6 to
3449c6d
Compare
|
Any update? This looks good to me. |
|
This shouldn't be needed after #123 which exercises both dev and release builds in CI. |
|
This will be closed by #124. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using
devprofile, even after tuning flags (to make it identical withrelease) still causes problems and is confusing for people.And even when we have BTF support in future, it'd be better and less confusing to set
debug=2inreleaseprofile (because we would want debug info, but still keep the same opt-level and other options).