Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add #![no_builtins] #98

Closed
wants to merge 1 commit into from
Closed

Add #![no_builtins] #98

wants to merge 1 commit into from

Conversation

tamird
Copy link
Member

@tamird tamird commented Jul 27, 2023

See aya-rs/aya#698 for rationale.

ajwerner
ajwerner approved these changes Jul 27, 2023
View reviewed changes
Copy link
Member

@ajwerner ajwerner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alessandrod
Copy link
Contributor

Can we close this? We've discussed on discord and I think we agree that no_builtins shouldn't be a thing

@alessandrod alessandrod mentioned this pull request Jul 29, 2023
Closed
@tamird tamird marked this pull request as draft July 29, 2023 02:44
@tamird tamird closed this Jan 8, 2024
@tamird tamird deleted the no-builtins branch January 8, 2024 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajwerner ajwerner ajwerner approved these changes

@alessandrod alessandrod Awaiting requested review from alessandrod

@vadorovsky vadorovsky Awaiting requested review from vadorovsky

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tamird @alessandrod @ajwerner