Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove chart from dashboard #158

Merged
merged 4 commits into from
Feb 22, 2025
Merged

Remove chart from dashboard #158

merged 4 commits into from
Feb 22, 2025

Conversation

adelowo
Copy link
Contributor

@adelowo adelowo commented Feb 22, 2025 •
edited by jira bot
Loading

Fixes MAL-112

@codecov Codecov
Copy link

codecov bot commented Feb 22, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 80.76923% with 20 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
mocks/dashboard.go 0.00% 8 Missing ⚠️
internal/datastore/postgres/dashboard.go 83.78% 4 Missing and 2 partials ⚠️
server/dashboard.go 89.28% 4 Missing and 2 partials ⚠️
Files with missing lines Coverage Δ
server/http.go 96.70% <100.00%> (+0.02%) ⬆️
swagger/docs.go 0.00% <ø> (ø)
internal/datastore/postgres/dashboard.go 91.52% <83.78%> (-2.05%) ⬇️
server/dashboard.go 92.91% <89.28%> (-0.63%) ⬇️
mocks/dashboard.go 0.00% <0.00%> (ø)

@adelowo adelowo merged commit 93f0c25 into main Feb 22, 2025
4 checks passed
@adelowo adelowo deleted the MAL-112-i-should-be-able-to-remove-a-chart-from-a-dashboard branch February 22, 2025 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@adelowo