forked from micropython/micropython
-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate ubluepy #1
Open
glennrub
wants to merge
8
commits into
aykevl:bluetooth
Choose a base branch
from
glennrub:deprecate_ubluepy
base: bluetooth
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rebased to master with the help of Mirko Vogt.
This is useful for more advanced use cases, like iBeacon/Eddystone.
At the moment, only a service is created. Characteristics within a service cannot yet be added.
128-bit proprietary UUIDs can be passed using strings. Dashes and capitalization are ignored.
Add support for adding characteristics to services. They can be read and written on both the esp32 and the nrf. Events of any kind (notifications etc.) haven't been implemented yet.
Removing nrf-port Bluetooth LE drivers and micropython wrapper objects/modules. Also, deprecating the legacy examples using ubluepy.
Created https://github.com/glennrub/ubluepy -> clone to "cmodules"
|
aykevl
force-pushed
the
bluetooth
branch
2 times, most recently
from
June 12, 2019 19:33
995a201
to
a6d3588
Compare
aykevl
force-pushed
the
bluetooth
branch
2 times, most recently
from
August 2, 2019 09:03
e13f4c7
to
5b3afbc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm moving out ubluepy as a external cmodule that can be loaded using USER_C_MODULES.
This makes me do a few changes to the current proposal, explicitly the "MICROPY_PY_BLUETOOTH ?= 1" and "RF_STACK_ENABLED". The first to disable BLUETOOTH from micropython, but not the SoftDevice support as this is still needed if a Radio stack is hosted outside. The latter to override the "is_stack_enabled" in drivers like flash/random/temp. This is also applicable if someone would like to make a Radio module outside mainline source, and still utilize these drivers.