- Fix symbols not getting updated

ayushsharma82 · Sep 14, 2023 · 79cb805 · 79cb805
1 parent 4b56797
commit 79cb805
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 9 deletions.
diff --git a/library.json b/library.json
@@ -15,7 +15,7 @@
       "maintainer": true
     }
   ],
-  "version": "4.0.1",
+  "version": "4.0.2",
   "frameworks": "arduino",
   "platforms": "espressif",
   "dependencies":

diff --git a/library.properties b/library.properties
@@ -1,5 +1,5 @@
 name=ESP-DASH
-version=4.0.1
+version=4.0.2
 author=Ayush Sharma
 category=Communication
 maintainer=Ayush Sharma <[email protected]>

diff --git a/src/Card.cpp b/src/Card.cpp
@@ -36,10 +36,10 @@ void Card::update(int value, const char* symbol){
   }
   /* Store new value */
   _value_type = Card::INTEGER;
-  _symbol = symbol;
-  if(_value_i != value)
+  if(strcmp(_symbol.c_str(), symbol) != 0 || _value_i != value)
     _changed = true;
   _value_i = value;
+  _symbol = symbol;
 }
 
 void Card::update(int value){
@@ -61,10 +61,10 @@ void Card::update(float value, const char* symbol){
   }
   /* Store new value */
   _value_type = Card::FLOAT;
-  _symbol = symbol;
-  if(_value_f != value)
+  if(strcmp(_symbol.c_str(), symbol) != 0 || _value_f != value)
     _changed = true;
   _value_f = value;
+  _symbol = symbol;
 }
 
 void Card::update(float value){
@@ -92,7 +92,9 @@ void Card::update(const char* value, const char* symbol){
     if(strcmp(_value_s.c_str(), value) != 0)
       _changed = true;
   }
-
+  if (strcmp(_symbol.c_str(), symbol) != 0) {
+    _changed = true;
+  }
   _value_type = Card::STRING;
   _symbol = symbol;
   _value_s = value;
@@ -115,10 +117,10 @@ void Card::update(bool value, const char* symbol){
   }
   /* Store new value */
   _value_type = Card::INTEGER;
-  _symbol = symbol;
-  if(_value_i != value)
+  if(strcmp(_symbol.c_str(), symbol) != 0 || _value_i != value)
     _changed = true;
   _value_i = value;
+  _symbol = symbol;
 }
 
 void Card::update(bool value){