Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Close #3186 Use Composer to track az-icons package, and add ability for site owner to choose how az-icon library is loaded. #1465

Merged
merged 20 commits into from
Feb 23, 2024
Merged

Close #3186 Use Composer to track az-icons package, and add ability for site owner to choose how az-icon library is loaded. #1465

merged 20 commits into from
Feb 23, 2024

Conversation

trackleft
Copy link
Member

@trackleft trackleft commented Apr 8, 2022 •
edited
Loading

Description

In this PR I am

  1. Adding a new github action that utilizes repository dispatch paradigm to create a new PR upon new release of az-icons. (this matches what we do for arizona-bootstrap)
    2.Removing the copy of the icon font from this repository
  2. Adding theme settings and defaults for controlling the output of the library.
  3. Update composer.json so that it downloads az-icons

Related issues

Close #3186

How to test

Navigate to theme settings for az_barrio
Adjust the settings for az-icons
image
Save
Navigate to front end, and check that your settings are being respected.

Types of changes

Arizona Quickstart (install profile, custom modules, custom theme)

  • Patch release changes
    • Bug fix
    • Accessibility, performance, or security improvement
    • Critical institutional link or brand change
  • Minor release changes
    • New feature
    • Breaking or visual change to existing behavior
    • Non-critical brand change
    • New internal API or API improvement with backwards compatibility
    • Risky or disruptive cleanup to comply with coding standards
    • High-risk or disruptive change (requires upgrade path, risks regression, etc.)
  • Other or unknown

Drupal core

  • Patch release changes
    • Security update
    • Patch level release (non-security bug-fix release)
    • Patch removal that's no longer necessary
  • Minor release changes
    • Major or minor level update
  • Other or unknown

Drupal contrib projects

  • Patch release changes
    • Security update
    • Patch or minor level update
    • Add new module
    • Patch removal that's no longer necessary
  • Minor release changes
    • Major level update
  • Other or unknown

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

trackleft
trackleft commented Apr 8, 2022
View reviewed changes
composer.json Outdated Show resolved Hide resolved
@trackleft trackleft changed the title remove font add to composer Remove local copy of font and add it back with composer. Apr 9, 2022
@trackleft trackleft changed the title Remove local copy of font and add it back with composer. Remove local copy of font and add it back with composer and more theme setting options. Apr 9, 2022
@joeparsons joeparsons added the enhancement New feature or request label Apr 22, 2022
@trackleft
Copy link
Member Author

trackleft commented Apr 22, 2022 •
edited
Loading

Blocked by az-digital/az-icons#35

trackleft
trackleft commented Feb 16, 2024
View reviewed changes
Copy link
Member Author

@trackleft trackleft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor updates required

composer.json Outdated Show resolved Hide resolved
themes/custom/az_barrio/config/install/az_barrio.settings.yml Outdated Show resolved Hide resolved
trackleft
trackleft commented Feb 17, 2024
View reviewed changes
composer.json Outdated Show resolved Hide resolved
@trackleft trackleft changed the title Remove local copy of font and add it back with composer and more theme setting options. Close #3186 Use Composer to track az-icons package, and add ability for site owner to choose how az-icon library is loaded. Feb 17, 2024
@trackleft trackleft marked this pull request as ready for review February 17, 2024 01:48
@trackleft trackleft requested a review from a team as a code owner February 17, 2024 01:48
joeparsons
joeparsons previously approved these changes Feb 17, 2024
View reviewed changes
@joeparsons joeparsons added 2.10.x only ci Continuous integration / automation labels Feb 17, 2024
bberndt-uaz
bberndt-uaz previously approved these changes Feb 21, 2024
View reviewed changes
joeparsons
joeparsons previously approved these changes Feb 21, 2024
View reviewed changes
trackleft
trackleft commented Feb 21, 2024
View reviewed changes
themes/custom/az_barrio/config/install/az_barrio.settings.yml Outdated
@@ -86,6 +86,8 @@ az_bootstrap_cdn_version: stable
az_bootstrap_minified: true
az_barrio_az_icons: true
az_barrio_az_icons_source: cdn
az_barrio_az_icons_minified: true
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this was set when I was reviewing.

@trackleft trackleft dismissed stale reviews from joeparsons and bberndt-uaz via e9a0c7e February 21, 2024 17:48
@trackleft
Copy link
Member Author

Thanks @tadean , your suggestion to test on an existing site uncovered an issue with setting machine names. Updated here 0b15d76

I tested on https://icons-azs-eller.pantheonsite.io

@tadean tadean merged commit 7f01034 into main Feb 23, 2024
13 checks passed
@tadean tadean deleted the az-icons-issue-17/auto-tag-az-icons branch February 23, 2024 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bberndt-uaz bberndt-uaz bberndt-uaz approved these changes

@tadean tadean tadean approved these changes

@joeparsons joeparsons joeparsons left review comments

Assignees

@trackleft trackleft

Labels
2.10.x only ci Continuous integration / automation enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use composer to track the az-icons project instead of managing az-icons artifact in this repo.
4 participants
@trackleft @joeparsons @tadean @bberndt-uaz