-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closes #3820 Full-width paragraphs have a different width in the Content region compared to other regions #3859
base: main
Are you sure you want to change the base?
Conversation
@trackleft found that this PR can cause a horizontal scrollbar to be displayed when full-width paragraphs are present. Reverting to draft to work on this further. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I couldn't break it
Thanks @joshuasosa! Reverting to draft to:
|
db95bfc
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Probo site was unavailable, but I have rebuilt it and set up the test page again. I would welcome any further review and approvals! |
Description
This PR adjusts the styling of full-width regions and paragraphs to:
content
class in all regions so that they align vertically withcontent
divs in the Content region.As part of this PR, some styling is moved from
modules/custom/az_paragraphs/css/az_paragraphs_full_width.css
tothemes/custom/az_barrio/css/style.css
since it applies to paragraphs in other regions which may display as full width even when they do not have the "Full width" checkbox checked. For example, theaz-full-width-row
class is included in the view display for all Text on Media paragraphs, so the styling for that class should be available wherever those paragraphs can be used.Questions:
Release notes
Related issues
How to test
Probo review site: https://7b5e2985-cedf-4a13-ab91-3a35916c835d--pr-3859.probo.build
Test page: https://7b5e2985-cedf-4a13-ab91-3a35916c835d--pr-3859.probo.build/brian-test-page
Compare various arrangements of standard and full-width Text with Background and Text on Media paragraphs.
Types of changes
Arizona Quickstart (install profile, custom modules, custom theme)
Drupal core
Drupal contrib projects
Checklist