Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #3962 Alter Sort Order of user admin view #3973

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Conversation

tadean
Copy link
Contributor

@tadean tadean commented Jan 8, 2025

This PR alters the default sort order of user_admin_people, a view provided by drupal core, for the administration of users. This PR does so programmatically rather than by overriding the configuration because it is a view provided by Drupal core.

Description

This PR alters the default sort order of the style plugin for the user_admin_people view.

Related issues

#3962

How to test

  • create multiple users
  • login in as some of them
  • visit admin/people
  • verify they are initially sorted in access order
  • verify click sorting other columns still works

Types of changes

Arizona Quickstart (install profile, custom modules, custom theme)

  • Patch release changes
    • Bug fix
    • Accessibility, performance, or security improvement
    • Critical institutional link or brand change
    • Adding experimental module
    • Update experimental module
  • Minor release changes
    • New feature
    • Breaking or visual change to existing behavior
    • Upgrade experimental module to stable
    • Enable existing module by default or database update
    • Non-critical brand change
    • New internal API or API improvement with backwards compatibility
    • Risky or disruptive cleanup to comply with coding standards
    • High-risk or disruptive change (requires upgrade path, risks regression, etc.)
  • Other or unknown
    • Other or unknown

Drupal core

  • Patch release changes
    • Security update
    • Patch level release (non-security bug-fix release)
    • Patch removal that's no longer necessary
  • Minor release changes
    • Major or minor level update
  • Other or unknown
    • Other or unknown

Drupal contrib projects

  • Patch release changes
    • Security update
    • Patch or minor level update
    • Add new module
    • Patch removal that's no longer necessary
  • Minor release changes
    • Major level update
  • Other or unknown
    • Other or unknown

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • My change requires release notes.

@tadean tadean added visual change Introduces a visual change usability Improvements to usability of Quickstart components 2.13.x only labels Jan 8, 2025
@tadean tadean self-assigned this Jan 8, 2025
@tadean tadean marked this pull request as ready for review January 10, 2025 15:17
@tadean tadean requested a review from a team as a code owner January 10, 2025 15:17
@tadean
Copy link
Contributor Author

tadean commented Jan 10, 2025

In review, tentatively decided to follow the approach of overriding the view programmatically rather than maintaining our own copy of the core view.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.13.x only usability Improvements to usability of Quickstart components visual change Introduces a visual change
Projects
Status: Todo
Development

Successfully merging this pull request may close these issues.

1 participant