Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split seed from the settings string #18

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

pkmnfrk
Copy link

@pkmnfrk pkmnfrk commented Feb 21, 2019

I realize there are benefits to having as part of the settings string, including easier sharing and bug reporting. However, I think for most cases, it is better to be separated. This PR makes the following changes:

Benefits:

  • You can easily remember your favourite settings, and not have to worry about accidentally generating the exact same seed
  • You can easily roll multiple games with the same settings
  • More intuitive behaviour based on other randomizers (primarily looking at OOT, but I can't think of any other randomizer I have seen that does this)

…d add the Seed and Settings to the spoiler log. Also, make the spoiler log named and pathed identically to the rom
@@ -362,6 +368,11 @@ private void MakeSpoilerLog()
LogFile.Close();
}

private string SpoilerLogFilename()
{
return saveROM.FileName.Replace(".z64", ".txt");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the filename should still say SpoilerLog somewhere.

{
tSeed.Text = seedRng.Next().ToString();
}
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unpleasant mixture of tabs and spaces here and elsewhere in this pull request.

ProbablyButter pushed a commit to ProbablyButter/mm-rando that referenced this pull request May 17, 2019
Fix outputted files to all be in the same user-selected directory.
ProbablyButter pushed a commit to ProbablyButter/mm-rando that referenced this pull request May 17, 2019
Fix outputted files to all be in the same user-selected directory.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants