-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bootstrap Django API #419
Bootstrap Django API #419
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for putting this together! Overall, this looks really good. I found some smaller things that I think need to be addressed, and some larger architecture discussion items that might potentially lead to more work, or to other issues being created. Let me know what you think!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is working well! I found a few more things that I think should be changed but it looks like they've all got pretty easy resolutions, so this is good to go after cleaning those up!
- update docker-compose to include django and database services - add STRTA scripts for local development - bootstrap Django to be used as API backend with necessary dependencies, middleware, db config - update start command in the package.json for frontend so that it can proxy the django API locally - update README for the STRTA section - update gitignore to ignore byte-compiled python files and static files from Django
7173c86
to
d1d63a3
Compare
Overview
This PR:
django
anddatabase
services for local dev as API and DB./scripts/bootstrap
,./scripts/setup
,./scripts/update
,./scripts/manage
,./scripts/server
,./scripts/dbshell
/api/
API route and returns a message that shows the API works as expectedNotes
Testing Instructions
./scripts/setup
, which should bootstrap the app, install deps, build containers, and run migrations./scripts/server
, which should spin up a local DB, frontend, and Django API server/api/
call. Make sure the request is also successful./scripts/manage migrate
and make sure it runs migrations, although there is no migration to run now, which is fineAt the root of the directory, run./scripts/dbshell
and make sure it takes you to a localpsql
shell and you could do normal SQL stuffs thereResolves #414