Serve static files at Django root #454
Conversation
There was a problem hiding this comment.
I learned a lot about Docker volumes from reviewing this so thanks for adding me as a reviewer! As you can see from my comments, I wasn't able to get it to run as is; however, this was a tricky one trying to work around mastarm and the frontend and backend not sharing a root the same way they do in other projects, so good job isolating and addressing the issue on this one!
| @@ -28,6 +28,7 @@ services: | |||
| volumes: | |||
| - ./src/backend:/usr/local/src/backend | |||
| - $HOME/.aws:/root/.aws:ro | |||
| - ./taui/assets:/usr/local/src/backend/static/assets | |||
There was a problem hiding this comment.
| - ./taui/assets:/usr/local/src/backend/static/assets | |
| - ./taui/assets:/usr/local/src/backend/static/assets | |
| - ./taui/index.html:/usr/local/src/backend/static/index.html |
Unfortunately, copying index.html as a command didn't work for me; however, mounting it as its own volume did. I'm not sure whether this is best practice but it makes sense to me that this file could persist across Docker containers like the rest of the stuff in taui/assets.
There was a problem hiding this comment.
I'm thinking I must have already had the index.html file in my /static folder after trying to mount from before, so it was able to work for me locally but not actually in practice. This way makes sense to me and works well, so just pushed that change!
docker-compose.yml
Outdated
| @@ -40,6 +41,7 @@ services: | |||
| - "--error-logfile=-" | |||
| - "--log-level=debug" | |||
| - "echo.wsgi" | |||
| - "cp ./taui/index.html /usr/local/src/backend/static" | |||
There was a problem hiding this comment.
| - "cp ./taui/index.html /usr/local/src/backend/static" |
If mounting index.html as its own volume works, this is no longer necessary.
rachelekm
force-pushed
the
fix/rkm/django-static-files-fix
branch
from
8306279 to
507493c
Compare
Overview
We are currently using
django-spaand amastarmproxy onstartto serve static files, however these static files were previously inaccessible todjango-spa. This mounts the static assets created throughmastarmto the django/staticfolder, allowingdjango-spato findindex.htmlon call to/.Notes
index.htmlfile is not generated as part of themastarmbundler and needed to be separately copied in, which is unideal. Ultimately, this serves as a temporary fix until we can move forward with a different bundler in Switch to a different bundler #376.Testing Instructions
scripts/updatescripts/serverhttp://localhost:8085/and confirm static page loadsResolves #424