Fix 'bounds are not valid' console error #531
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR fixes the 'bounds are not valid' console error that was appearing on main page start. We set the map bounds using the
neighborhoodBoundsExtent
prop, which starts off asnull
beforedata.neighborhoodBounds
gets loaded with data and can update theneighborhoodBoundsExtent
selector. It looks like the map component renders while theneighborhoodBoundsExtent
prop is stillnull
and then re-renders once data loads/prop updates—why the map/functionality still worked. We weren't getting this error before, so I'm wondering if the bundler switch (PR #457) affected the timing in which the neighborhood bounds asset loads on app start and the map component render just happens to catch it a little too early now? Either way, I just added a conditional to render ifneighborhoodBoundsExtent
isn'tnull
and that seemed to do the trick.Checklist
./scripts/format
to lint, format, and fix the application source code.Testing Instructions
scripts/server
Resolves #520