Add max_allocated_storage param, and update some defaults #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a max_allocated_storage variable to match the new parameter available on the postgresql component. Defaults to 0, i.e. no storage auto-scaling. Also updates the README lines about the storage parameters, and a few others that were nearby and glaringly out of date.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the
max_allocated_storageparameter, and a variable to provide a value for it. The default is0, i.e. no automatic storage scaling.While I was in the variables file and README to add that, I also updated a few defaults to more modern values, including changing the default storage class to gp3. It's cheaper and faster, so it makes sense as a default, though the relationship with the
iopsparameter is a bit complicated—above 400GB, you can pick how much you want, but below that there's a fixed value, 3000 IOPS. The IOPS value will automatically get set to that, but if you don't have the parameter set, Terraform will register it as a change (3000 -> null). I'm not sure if applying that would crash, throw an error and ignore the change, or what, because I didn't try. But that's why the IOPS default is now 3000.Resolves #40