-
Notifications
You must be signed in to change notification settings - Fork 287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add theme: PlainTasks Markdown #246
base: master
Are you sure you want to change the base?
Conversation
NAVER - http://www.naver.com/[email protected] 님께 보내신 메일 <[PlainTasks] Add theme: PlainTasks Markdown (#246)> 이 다음과 같은 이유로 전송 실패했습니다. 받는 사람이 회원님의 메일을 수신차단 하였습니다. |
@@ -1,4 +1,4 @@ | |||
{ | |||
bl PL{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NAVER - http://www.naver.com/
[email protected] 님께 보내신 메일 <Re: [PlainTasks] Add theme: PlainTasks Markdown (#246)> 이 다음과 같은 이유로 전송 실패했습니다.
받는 사람이 회원님의 메일을 수신차단 하였습니다.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have no idea. Running a processor-intensive ImageOptim-task and noticed ST kinda lags, so I guess that caused it. Will fix...
It doesn’t support url scope, is it intentional? If yes, it’s okay, I just want to be sure. It doesn’t support ST2:
This is problem, we claim supprt for both ST so far (since 3 is still in beta), please ensure ST2 support, otherwise I have to reject. |
Not intentional and yeah, only ST3 supported for now. I was too hasty, so feel free to reject. Maybe getting back on to this in the future. |
@ronilaukkarinen I’m sorry, it is my mistake, it does support ST2 just fine, the reason for error is that I set wrong path (User instead of PlainTasks). So if you want to add url scope, just go ahead, then ping me, and it’s good to merge. |
@vovkkk Ok, thanks for clarifying that, I don't have ST2 installed myself so wasn't sure. I'll add the url scope in some point and get back on this. |
Ooh, also there are bold and italic scopes, if you’ve missed them. |
Do you have a certain spec which scopes are needed? because I have created the scheme based on MarkdownEditing theme so I'm exactly not quite sure what else might be missing. |
|
Ref: #244 #244