Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Dockerfile with devcontainer.json for Azure SRE TF provider #295

Merged
merged 1 commit into from
Nov 30, 2024

Conversation

arnaudlh
Copy link
Member

@arnaudlh arnaudlh commented Nov 29, 2024

Transition from a Dockerfile to a devcontainer.json configuration to streamline the development environment setup for the Azure SRE Terraform provider. This change enhances the container's features and customizations.

Devcontainer Configuration Updates:

  • .devcontainer/Dockerfile: The Dockerfile has been removed, which previously included the setup for Go tools, Azure CLI, and Terraform.

  • .devcontainer/devcontainer.json: The devcontainer configuration has been updated to use a specific image (mcr.microsoft.com/devcontainers/base:jammy) instead of a custom Dockerfile. New features and customizations have been added, including Azure CLI, Go, GitHub CLI, Terraform, and Zsh plugins. Additionally, several VS Code extensions are now included by default.

@arnaudlh arnaudlh requested a review from Copilot November 29, 2024 03:43

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.

Files not reviewed (2)
  • .devcontainer/Dockerfile: Language not supported
  • .devcontainer/devcontainer.json: Language not supported

Tip: If you use Visual Studio Code, you can request a review from Copilot before you push from the "Source Control" tab. Learn more

@arnaudlh arnaudlh self-assigned this Nov 29, 2024
@arnaudlh arnaudlh added enhancement New feature or request dependencies Pull requests that update a dependency file labels Nov 29, 2024
@arnaudlh arnaudlh added this to the 1.2.29 milestone Nov 29, 2024
Copy link
Contributor

@LaurentLesle LaurentLesle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@arnaudlh arnaudlh merged commit 835b281 into aztfmod:main Nov 30, 2024
2 checks passed
@arnaudlh arnaudlh deleted the modern-devcontainers branch November 30, 2024 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file enhancement New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants