Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use FeatureSpaces as FeatureValue factories #21

Open
b-adkins opened this issue Jul 29, 2014 · 0 comments
Open

Use FeatureSpaces as FeatureValue factories #21

b-adkins opened this issue Jul 29, 2014 · 0 comments

Comments

@b-adkins
Copy link
Owner

Why?

  • Check FeatureValues validity at initialization. Thus, invalid FeatureValues DON'T EXIST. (Perhaps a pointer in each FeatureValue linking to its FeatureSpace? This could compile out for speed, but would be useful for reliability.)
  • FeatureSpaces know how to create valid FeatureValues for themselves.
  • Possiblity: specialized ROS callbacks to create FeatureValues, which are passed to polymorphic code that doesn't anything about them.

Changes:

  • Add the following methods to appropriate FeatureSpaces:
    shared_ptr FeatureSpace::createValue(int discrete)
    shared_ptr FeatureSpace::createValue(std::vector belief)
    shared_ptr FeatureSpace::createValue(std::vector vector)
  • Make FeatureValue constructors private.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant