-
Notifications
You must be signed in to change notification settings - Fork 149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhance json schema #353
Enhance json schema #353
Conversation
EmilyGraceSeville7cf
commented
Jan 27, 2024
- enable intellisence for programs/*.json configs
- add repo url to schema hints
- add examples for properties
- disallow space only strings for properties
Provide: - examples - better descriptions - url to repo Disallow: - space only strings
First of all, this is very cool, thank you for implementing it! I believe the failed unit test is because some of the program configs don't follow the stricter rules you've specified. (Mainly that the help can't be empty) Here's the list of failing configs:
I'll try to fix these, but it may take me a while since exams are coming up. If anyone wants to help, just update the help sections in those configs so they're not empty anymore and submit a PR for them. |
Use 'Not provided' placeholder
As a quick workaround (as I don't know your code internals) I've added a new suggested value |
Should be fixed with #374, could you update your branch? |
This reverts commit 2a939cf.
@b3nj5m1n, I did it. ;) |
Alright, I think we're good to go, thank you again for this! |