Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add diagnostics for source generators #1337

Merged
merged 2 commits into from
Jan 7, 2024
Merged

feat: Add diagnostics for source generators #1337

merged 2 commits into from
Jan 7, 2024

Conversation

linkdotnet
Copy link
Collaborator

We would help out users, if we report some diagnostics for our generators.

@linkdotnet linkdotnet requested a review from egil January 5, 2024 13:24
egil
egil previously approved these changes Jan 5, 2024
View reviewed changes
Copy link
Member

@egil egil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Can we include a deep link to an .md with further details?

@linkdotnet
Copy link
Collaborator Author

Looks good. Can we include a deep link to an .md with further details?

Good idea! Done!

@linkdotnet linkdotnet requested a review from egil January 6, 2024 12:28
@linkdotnet linkdotnet merged commit c8ba524 into main Jan 7, 2024
10 checks passed
@linkdotnet linkdotnet deleted the report-diagnostics branch January 7, 2024 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@egil egil egil approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@linkdotnet @egil