-
-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Added support for keyed services #1374
Conversation
8f87eeb
to
0147ff3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm
Seems like they updated the linux runner and now we get this in our CI-pipeline:
I don't see any other reason why our |
hmm can we just remove the |
We can, we did, let's see if the build is happy now ;) |
a8e1818
to
7bb2895
Compare
At least we are one error further:
|
@@ -13,19 +13,20 @@ | |||
</PropertyGroup> | |||
|
|||
<ItemGroup> | |||
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.9.0" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See commit: ac0b0b7
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So is this the bits that prevent the blame stuff to work, actually? seems odd that --blame should stop working, its a breaking change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let me re-add the part and let's see what is gonna happen
1665b2e
to
b08f51a
Compare
Pull request description
Closes #1373
PR meta checklist
main
branch for codeor targeted at
stable
branch for documentation that is live on bunit.dev.Code PR specific checklist