Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added support for keyed services #1374

Merged
merged 1 commit into from
Feb 14, 2024
Merged

feat: Added support for keyed services #1374

merged 1 commit into from
Feb 14, 2024

Conversation

linkdotnet
Copy link
Collaborator

Pull request description

Closes #1373

PR meta checklist

  • Pull request is targeted at main branch for code
    or targeted at stable branch for documentation that is live on bunit.dev.
  • Pull request is linked to all related issues, if any.
  • I have read the CONTRIBUTING.md document.

Code PR specific checklist

  • My code follows the code style of this project and AspNetCore coding guidelines.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
  • I have updated the appropriate sub section in the CHANGELOG.md.
  • I have added, updated or removed tests to according to my changes.
    • All tests passed.

@linkdotnet linkdotnet requested a review from egil February 12, 2024 18:16
@linkdotnet linkdotnet force-pushed the feature/keyed-services branch from 8f87eeb to 0147ff3 Compare February 12, 2024 18:29
egil
egil previously approved these changes Feb 12, 2024
Copy link
Member

@egil egil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@linkdotnet
Copy link
Collaborator Author

Seems like they updated the linux runner and now we get this in our CI-pipeline:

Data collector 'Blame' message: Could not start process dump: System.PlatformNotSupportedException: Unsupported operating system: Ubuntu 22.04.3 LTS, and framework: .NETCoreApp,Version=v3.1.

I don't see any other reason why our run-test fails.

@egil
Copy link
Member

egil commented Feb 13, 2024

hmm can we just remove the --blame?

@linkdotnet
Copy link
Collaborator Author

We can, we did, let's see if the build is happy now ;)

@linkdotnet linkdotnet force-pushed the feature/keyed-services branch 2 times, most recently from a8e1818 to 7bb2895 Compare February 13, 2024 16:26
@linkdotnet
Copy link
Collaborator Author

At least we are one error further:

An assembly specified in the application dependencies manifest (Bunit.Web.AngleSharp.Tests.deps.json) was not found:

package: 'AngleSharp', version: '1.0.7'
path: 'lib/net8.0/AngleSharp.dll'

@@ -13,19 +13,20 @@
</PropertyGroup>

<ItemGroup>
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.9.0" />
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

See commit: ac0b0b7

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So is this the bits that prevent the blame stuff to work, actually? seems odd that --blame should stop working, its a breaking change.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let me re-add the part and let's see what is gonna happen

@linkdotnet linkdotnet requested a review from egil February 13, 2024 19:19
egil
egil previously approved these changes Feb 14, 2024
@egil egil merged commit e259795 into main Feb 14, 2024
10 checks passed
@egil egil deleted the feature/keyed-services branch February 14, 2024 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for keyed services
2 participants