Fix #109

ba-st · Aug 12, 2024 · 43141db · 43141db
1 parent 7193725
commit 43141db
Show file tree

Hide file tree

Showing 2 changed files with 26 additions and 1 deletion.
diff --git a/source/Sagan-Core-Tests/RepositoryBasedTest.class.st b/source/Sagan-Core-Tests/RepositoryBasedTest.class.st
@@ -257,6 +257,31 @@ RepositoryBasedTest >> testFindAllMatchingLimitedToSortedByAscending [
 
 ]
 
+{ #category : 'tests - querying' }
+RepositoryBasedTest >> testFindAllMatchingLimitedToSortedByAscendingLimitGreaterThanNumberOfMatchingElements [
+
+  | results |
+  self extraterrestrials
+    store: self silvesterStallone;
+    store: self silvesterMcCoy;
+    store: self johnTravolta;
+    store: self johnLock.
+
+  results := self extraterrestrials
+               findAllMatching: [ :extraterrestrial :criteria |
+                   criteria does: extraterrestrial lastName asUppercase includeSubstring: 'L' ]
+               limitedTo: 4
+			sortedByAscending: #lastName.
+
+  self
+    assert: results size equals: 3;
+    assert: ( results anySatisfy: [ :result | result lastName = 'Lock' ] );
+    deny: ( results anySatisfy: [ :result | result lastName = 'McCoy' ] );
+    assert: ( results anySatisfy: [ :result | result lastName = 'Stallone' ] );
+    assert: ( results anySatisfy: [ :result | result lastName = 'Travolta' ] )
+
+]
+
 { #category : 'tests - querying' }
 RepositoryBasedTest >> testFindAllMatchingSortedBy [
 

diff --git a/source/Sagan-Core/InMemoryRepository.class.st b/source/Sagan-Core/InMemoryRepository.class.st
@@ -73,7 +73,7 @@ InMemoryRepository >> findAllMatching: aCriteriaOrBlock [
 InMemoryRepository >> findAllMatching: aCriteriaOrBlock limitedTo: aMaxNumberOfResults sortedByAscending: aVariableName [
 
   ^ ( ( self contentsSortedByAscending: aVariableName ) select:
-        ( self asMatchingCriteria: aCriteriaOrBlock ) ) copyFirst: aMaxNumberOfResults
+        ( self asMatchingCriteria: aCriteriaOrBlock ) ) copyNoMoreThanFirst: aMaxNumberOfResults
 ]
 
 { #category : 'querying' }