Corrected test assertion to prevent assuming order of results

ba-st · Jan 5, 2024 · fa5224b · fa5224b
1 parent 6be4a73
commit fa5224b
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 3 deletions.
diff --git a/source/Sagan-Core-Tests/RepositoryBasedTest.class.st b/source/Sagan-Core-Tests/RepositoryBasedTest.class.st
@@ -24,8 +24,12 @@ RepositoryBasedTest class >> isAbstract [
 RepositoryBasedTest >> assertRepositoryIncludesSilvesterStallone [
 
 	self extraterrestrials
-		withOneMatching: [ :extraterrestrial | extraterrestrial firstName = 'Silvester' ]
-		do: [ :extraterrestrial | self assert: extraterrestrial lastName equals: 'Stallone' ]
+		withOneMatching: [ :extraterrestrial |
+			extraterrestrial firstName = 'Silvester' and: [ extraterrestrial lastName = 'Stallone' ] ]
+		do: [ :extraterrestrial |
+			self assert:
+				( extraterrestrial firstName = 'Silvester' and: [ extraterrestrial lastName = 'Stallone' ] )
+			]
 		else: [ self fail ]
 ]
 

diff --git a/source/Sagan-GemStone/GemStoneRepository.class.st b/source/Sagan-GemStone/GemStoneRepository.class.st
@@ -66,7 +66,7 @@ GemStoneRepository >> findAllMatching: aCriteriaOrBlock sortedBy: aSortFunction
 GemStoneRepository >> initializeCheckingConflictsAccordingTo: aConflictCheckingStrategy [
 
 	conflictCheckingStrategy := aConflictCheckingStrategy.
-	contents := OrderedCollection new
+	contents := Bag new
 ]
 
 { #category : 'private - accessing' }