Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added identifier facilities to image web views #220

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 16 additions & 6 deletions .github/workflows/loading-groups.yml
Original file line number Diff line number Diff line change
@@ -1,18 +1,28 @@
name: Baseline Groups

on: [push,pull_request,workflow_dispatch]

on:
- push
- pull_request
- workflow_dispatch
jobs:
group-loading:
runs-on: ubuntu-latest
strategy:
fail-fast: false
matrix:
smalltalk: [ Pharo64-11, Pharo64-10, Pharo64-9.0, Pharo64-8.0 ]
load-spec: [ deployment, dependent-sunit-extensions, tests, tools, development ]
smalltalk:
- Pharo64-11
- Pharo64-10
- Pharo64-9.0
- Pharo64-8.0
load-spec:
- deployment
- dependent-sunit-extensions
- tests
- tools
- development
name: ${{ matrix.smalltalk }} + ${{ matrix.load-spec }}
steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4
- uses: hpi-swa/setup-smalltalkCI@v1
with:
smalltalk-image: ${{ matrix.smalltalk }}
Expand Down
7 changes: 5 additions & 2 deletions .github/workflows/markdown-lint.yml
Original file line number Diff line number Diff line change
@@ -1,11 +1,14 @@
name: Markdown Lint
on: [push,pull_request,workflow_dispatch]
on:
- push
- pull_request
- workflow_dispatch
jobs:
remark-lint:
name: runner / markdownlint
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4
- name: markdownlint
uses: reviewdog/action-markdownlint@v0
with:
Expand Down
21 changes: 13 additions & 8 deletions .github/workflows/unit-tests.yml
Original file line number Diff line number Diff line change
@@ -1,17 +1,22 @@
name: Unit Tests

on: [push,pull_request,workflow_dispatch]

name: Pharo Unit Tests
on:
- push
- pull_request
- workflow_dispatch
jobs:
build:
unit-tests:
runs-on: ubuntu-latest
strategy:
matrix:
smalltalk: [ Pharo64-11, Pharo64-10, Pharo64-9.0, Pharo64-8.0 ]
smalltalk:
- Pharo64-11
- Pharo64-10
- Pharo64-9.0
- Pharo64-8.0
fail-fast: false
name: ${{ matrix.smalltalk }}
steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4
- name: Set up Smalltalk CI
uses: hpi-swa/setup-smalltalkCI@v1
with:
Expand All @@ -22,7 +27,7 @@ jobs:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
timeout-minutes: 15
- name: Upload coverage to Codecov
uses: codecov/codecov-action@v3
uses: codecov/codecov-action@v4
with:
name: Unit-Tests-${{matrix.smalltalk}}
token: ${{ secrets.CODECOV_TOKEN }}
Original file line number Diff line number Diff line change
@@ -1,10 +1,12 @@
Class {
#name : #AddTimestampToSourceCommandTest,
#superclass : #BWRenderingTest,
#category : #'Willow-Core-Tests-Frontend'
#name : 'AddTimestampToSourceCommandTest',
#superclass : 'BWRenderingTest',
#category : 'Willow-Core-Tests-Frontend',
#package : 'Willow-Core-Tests',
#tag : 'Frontend'
}

{ #category : #'tests-processing' }
{ #category : 'tests-processing' }
AddTimestampToSourceCommandTest >> testApplyToOn [

| html upToTime afterTime |
Expand Down
24 changes: 13 additions & 11 deletions source/Willow-Core-Tests/AjaxAwareErrorHandlerTest.class.st
Original file line number Diff line number Diff line change
Expand Up @@ -2,12 +2,14 @@
An AjaxAwareErrorHandlerTest is a test class for testing the behavior of AjaxAwareErrorHandler
"
Class {
#name : #AjaxAwareErrorHandlerTest,
#superclass : #WAErrorHandlerTest,
#category : #'Willow-Core-Tests-Applications'
#name : 'AjaxAwareErrorHandlerTest',
#superclass : 'WAErrorHandlerTest',
#category : 'Willow-Core-Tests-Applications',
#package : 'Willow-Core-Tests',
#tag : 'Applications'
}

{ #category : #accessing }
{ #category : 'accessing' }
AjaxAwareErrorHandlerTest >> createHttpXmlRequestContext [

| request |
Expand All @@ -21,7 +23,7 @@ AjaxAwareErrorHandlerTest >> createHttpXmlRequestContext [
^ WARequestContext request: request response: WABufferedResponse new
]

{ #category : #accessing }
{ #category : 'accessing' }
AjaxAwareErrorHandlerTest >> handlerClass [

^ AjaxAwareErrorHandlerFactory new
Expand All @@ -30,7 +32,7 @@ AjaxAwareErrorHandlerTest >> handlerClass [
yourself
]

{ #category : #accessing }
{ #category : 'accessing' }
AjaxAwareErrorHandlerTest >> testAssertionFailed [

| context reportingActionWasEvaluated updateRootBlockWasEvaluated renderingBlockWasEvaluated |
Expand Down Expand Up @@ -60,7 +62,7 @@ AjaxAwareErrorHandlerTest >> testAssertionFailed [
self fail
]

{ #category : #accessing }
{ #category : 'accessing' }
AjaxAwareErrorHandlerTest >> testHandleErrorInAjaxCall [

| context |
Expand All @@ -76,7 +78,7 @@ AjaxAwareErrorHandlerTest >> testHandleErrorInAjaxCall [
self fail
]

{ #category : #accessing }
{ #category : 'accessing' }
AjaxAwareErrorHandlerTest >> testHandlerErrorInAjaxCallReferencingHandler [

| context ajaxHandlerWasEvaluated |
Expand All @@ -93,7 +95,7 @@ AjaxAwareErrorHandlerTest >> testHandlerErrorInAjaxCallReferencingHandler [
self assert: ajaxHandlerWasEvaluated
]

{ #category : #accessing }
{ #category : 'accessing' }
AjaxAwareErrorHandlerTest >> testReportingActionArgumentsAreOptional [

| context reportingActionWasEvaluated |
Expand All @@ -117,7 +119,7 @@ AjaxAwareErrorHandlerTest >> testReportingActionArgumentsAreOptional [
self fail
]

{ #category : #accessing }
{ #category : 'accessing' }
AjaxAwareErrorHandlerTest >> testXmlHttpRequest [

| context |
Expand All @@ -131,7 +133,7 @@ AjaxAwareErrorHandlerTest >> testXmlHttpRequest [
do: [ :n | self fail ]
]

{ #category : #accessing }
{ #category : 'accessing' }
AjaxAwareErrorHandlerTest >> testXmlHttpRequestWithResumable [

| context handlerWasEvaluated |
Expand Down
18 changes: 10 additions & 8 deletions source/Willow-Core-Tests/AlertingCommandTest.class.st
Original file line number Diff line number Diff line change
Expand Up @@ -2,40 +2,42 @@
An AlertingCommandTest is a test class for testing the behavior of AlertingCommand
"
Class {
#name : #AlertingCommandTest,
#superclass : #BWRenderingTest,
#name : 'AlertingCommandTest',
#superclass : 'BWRenderingTest',
#instVars : [
'command'
],
#category : #'Willow-Core-Tests-WebInteraction'
#category : 'Willow-Core-Tests-WebInteraction',
#package : 'Willow-Core-Tests',
#tag : 'WebInteraction'
}

{ #category : #initialization }
{ #category : 'initialization' }
AlertingCommandTest >> setUp [

super setUp.
command := AlertingCommand stating: 'Great!'
]

{ #category : #'tests-accessing' }
{ #category : 'tests-accessing' }
AlertingCommandTest >> testModelLoadingInstructions [

self assert: command modelLoadingInstructions isEmpty
]

{ #category : #'tests-accessing' }
{ #category : 'tests-accessing' }
AlertingCommandTest >> testPriorityActions [

self assert: command priorityActions isEmpty
]

{ #category : #'tests-testing' }
{ #category : 'tests-testing' }
AlertingCommandTest >> testRequiresSerialization [

self deny: command requiresSerialization
]

{ #category : #'tests-accessing' }
{ #category : 'tests-accessing' }
AlertingCommandTest >> testServerIndependentInstructions [

| html |
Expand Down
16 changes: 9 additions & 7 deletions source/Willow-Core-Tests/AsynchronicButtonWebViewTest.class.st
Original file line number Diff line number Diff line change
Expand Up @@ -2,12 +2,14 @@
An AsynchronicButtonWebViewTest is a test class for testing the behavior of AsynchronicButtonWebView
"
Class {
#name : #AsynchronicButtonWebViewTest,
#superclass : #BWRenderingTest,
#category : #'Willow-Core-Tests-WebViews'
#name : 'AsynchronicButtonWebViewTest',
#superclass : 'BWRenderingTest',
#category : 'Willow-Core-Tests-WebViews',
#package : 'Willow-Core-Tests',
#tag : 'WebViews'
}

{ #category : #'tests-rendering' }
{ #category : 'tests-rendering' }
AsynchronicButtonWebViewTest >> testBeIdentifiable [

| button html |
Expand All @@ -18,7 +20,7 @@ AsynchronicButtonWebViewTest >> testBeIdentifiable [
self assert: html equals: '<button id="button-id1" type="button">Click me!</button>'
]

{ #category : #'tests-rendering' }
{ #category : 'tests-rendering' }
AsynchronicButtonWebViewTest >> testIdentifierOn [

| button html |
Expand All @@ -34,7 +36,7 @@ AsynchronicButtonWebViewTest >> testIdentifierOn [
self assert: html equals: '<button id="button-id1" type="button">Click me!</button>'
]

{ #category : #'tests-rendering' }
{ #category : 'tests-rendering' }
AsynchronicButtonWebViewTest >> testOn [

| button html |
Expand All @@ -48,7 +50,7 @@ AsynchronicButtonWebViewTest >> testOn [
'<button id="button-id1" type="button">Click me!</button><script type="text/javascript">$("#button-id1").click(function(event){$(this).prop("disabled",true)});</script>'
]

{ #category : #'tests-rendering' }
{ #category : 'tests-rendering' }
AsynchronicButtonWebViewTest >> testRenderContentOn [

| button html |
Expand Down
10 changes: 6 additions & 4 deletions source/Willow-Core-Tests/AutoFocusComponentCommandTest.class.st
Original file line number Diff line number Diff line change
@@ -1,10 +1,12 @@
Class {
#name : #AutoFocusComponentCommandTest,
#superclass : #BWRenderingTest,
#category : #'Willow-Core-Tests-Frontend'
#name : 'AutoFocusComponentCommandTest',
#superclass : 'BWRenderingTest',
#category : 'Willow-Core-Tests-Frontend',
#package : 'Willow-Core-Tests',
#tag : 'Frontend'
}

{ #category : #'tests-processing' }
{ #category : 'tests-processing' }
AutoFocusComponentCommandTest >> testApplyToOn [

| html |
Expand Down
22 changes: 12 additions & 10 deletions source/Willow-Core-Tests/BinaryChoiceWebViewTest.class.st
Original file line number Diff line number Diff line change
Expand Up @@ -2,33 +2,35 @@
I'm an abstract test case for views implementing the binary choice API
"
Class {
#name : #BinaryChoiceWebViewTest,
#superclass : #BWRenderingTest,
#name : 'BinaryChoiceWebViewTest',
#superclass : 'BWRenderingTest',
#instVars : [
'notificationWasReceived'
],
#category : #'Willow-Core-Tests-WebViews'
#category : 'Willow-Core-Tests-WebViews',
#package : 'Willow-Core-Tests',
#tag : 'WebViews'
}

{ #category : #testing }
{ #category : 'testing' }
BinaryChoiceWebViewTest class >> isAbstract [

^self name = #BinaryChoiceWebViewTest
]

{ #category : #support }
{ #category : 'support' }
BinaryChoiceWebViewTest >> changeNotifiedBy: aCheckboxWebView [

notificationWasReceived := true
]

{ #category : #support }
{ #category : 'support' }
BinaryChoiceWebViewTest >> newBinaryChoiceView [

^self subclassResponsibility
]

{ #category : #'tests-Binary Choice-API' }
{ #category : 'tests-Binary Choice-API' }
BinaryChoiceWebViewTest >> testAllows [

| binaryChoiceView |
Expand All @@ -41,7 +43,7 @@ BinaryChoiceWebViewTest >> testAllows [
deny: (binaryChoiceView allows: 1)
]

{ #category : #'tests-Binary Choice-API' }
{ #category : 'tests-Binary Choice-API' }
BinaryChoiceWebViewTest >> testControlSelection [

| binaryChoiceView |
Expand All @@ -58,7 +60,7 @@ BinaryChoiceWebViewTest >> testControlSelection [
self deny: binaryChoiceView currentSelection
]

{ #category : #'tests-Binary Choice-API' }
{ #category : 'tests-Binary Choice-API' }
BinaryChoiceWebViewTest >> testCurrentSelection [

| binaryChoiceView |
Expand All @@ -74,7 +76,7 @@ BinaryChoiceWebViewTest >> testCurrentSelection [
self assert: binaryChoiceView currentSelection
]

{ #category : #'tests-Binary Choice-API' }
{ #category : 'tests-Binary Choice-API' }
BinaryChoiceWebViewTest >> testNotifyChangesWhenSelectionChanged [

| binaryChoiceView |
Expand Down
Loading