chore(inactivity): Rename inactive flag to sluggish, add queries, events, and metrics
#714
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…reverting inactive flag (#689)
…bylonchain/babylon into base/jail-inactive-finality-providers
| // provider is no longer considered sluggish | ||
| message EventSluggishFinalityProviderReverted { | ||
| // public_key is the BTC public key of the finality provider | ||
| string public_key = 1; |
There was a problem hiding this comment.
can we also add the bbn address of the fp to the events
There was a problem hiding this comment.
I woudn't mind but what would be the use case?
| @@ -225,3 +225,51 @@ func (k Keeper) ListEvidences(ctx context.Context, req *types.QueryListEvidences | |||
| } | |||
| return resp, nil | |||
| } | |||
|
|
|||
| // SigningInfo returns signing-info of a specific finality provider. | |||
| func (k Keeper) SigningInfo(ctx context.Context, req *types.QuerySigningInfoRequest) (*types.QuerySigningInfoResponse, error) { | |||
RafilxTenfen
approved these changes
Jul 16, 2024
KonradStaniec
approved these changes
Jul 17, 2024
Yeah, tbh it's werid to me, too, but it's just temporal and will be changed to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
inactiveflag of a finality provider is confused with the finality providers that are not in the active set. So, this PR is to rename the flag tosluggish, which is a common concept in the BFT world to describe validators who should vote but the votes are delayed for some reason thus committing sluggish faults.This PR also made the following additions: