chore: e2e improve docker cache #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n into rafilx/e2e-improve-parallel
…p/bbn-e2e-testnet-2820217771/bbn-test-a/bbn-test-a-node-babylon-default-a-2/ibc_08-wasm/state/wasm: permission denied
RafilxTenfen
requested review from
maurolacy,
KonradStaniec,
SebastianElvis and
gitferry
…io/babylon into rafilx/e2e-improve-docker-cache
…n into rafilx/e2e-improve-docker-cache
KonradStaniec
approved these changes
Aug 9, 2024
RafilxTenfen
added a commit
that referenced
this pull request
Aug 9, 2024
Add upgrade to insert BTC headers Should be merged after #16
vitsalis
pushed a commit
that referenced
this pull request
Aug 14, 2024
- Add multiple CI jobs to run e2e - `e2e-docker-build-*` builds docker and saves it as an artifact - `e2e-run-*` runs each e2e test individually - remove the need of sudo on running e2e tests due to removing error check in ClearResources 🥲 it errors out due to `unlinkat /tmp/bbn-e2e-testnet-2820217771/bbn-test-a/bbn-test-a-node-babylon-default-a-2/ibc_08-wasm/state/wasm: permission denied` - removing the need of sudo to run e2e speeds up the run because it uses the go cache created from job `build` TLDR; It is not a pretty solution, but reduces the CI running time of e2e > Accepting suggestions/inputs to make it better  :heavy_check_mark: CI time reduced to 8min
vitsalis
pushed a commit
that referenced
this pull request
Aug 14, 2024
Add upgrade to insert BTC headers Should be merged after #16
maurolacy
reviewed
Aug 26, 2024
| @@ -40,12 +40,11 @@ func (cb *CurrentBranchConfigurer) ConfigureChains() error { | |||
|
|
|||
| func (cb *CurrentBranchConfigurer) ConfigureChain(chainConfig *chain.Config) error { | |||
| cb.t.Logf("starting e2e infrastructure from current branch for chain-id: %s", chainConfig.Id) | |||
| tmpDir, err := os.MkdirTemp("", "bbn-e2e-testnet-") | |||
| tmpDir, err := os.MkdirTemp("", "bbn-e2e-testnet-*") | |||
There was a problem hiding this comment.
What is this? Just curious.
There was a problem hiding this comment.
// If pattern includes a "*", the random string replaces the last "*" instead.
func MkdirTemp(dir, pattern string) (string, error) {| }, | ||
| withUpgrade(baseSetup), // base set up with upgrade | ||
| containerManager, | ||
| upgradePath, | ||
| 0, | ||
| ), nil | ||
| } | ||
|
|
||
| func identifierName(t *testing.T) string { |
There was a problem hiding this comment.
Why is this needed? Just curious.
There was a problem hiding this comment.
If you would run two or more tests at the same time they might match the name of the container and mess up everything 🤯
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
e2e-docker-build-*builds docker and saves it as an artifacte2e-run-*runs each e2e test individuallyit errors out due to
unlinkat /tmp/bbn-e2e-testnet-2820217771/bbn-test-a/bbn-test-a-node-babylon-default-a-2/ibc_08-wasm/state/wasm: permission deniedbuildTLDR; It is not a pretty solution, but reduces the CI running time of e2e
✔️ CI time reduced to 8min