fix: Proposal vote extensions' byte limit #585
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gitferry
force-pushed
the
gai/fix-prepare-proposal
branch
from
26fb2cf to
be9062d
Compare
gitferry
force-pushed
the
gai/fix-prepare-proposal
branch
from
be9062d to
d9c1096
Compare
KonradStaniec
approved these changes
Mar 3, 2025
| } | ||
|
|
||
| // SetCheckpointTx sets the tx used for checkpoint | ||
| func (t *PrepareProposalTxs) SetCheckpointTx(tx []byte) error { |
There was a problem hiding this comment.
maybe lets change name to SerOrReplaceCheckpointTx ?
|
|
||
| // AddOtherTxs adds txs to the "other" tx category and return early | ||
| // if all the remaining bytes are used up | ||
| func (t *PrepareProposalTxs) AddOtherTxs(allTxs [][]byte) error { |
There was a problem hiding this comment.
Maybe ReplaceOtherTxs ? Add suggests that it would extend exsiting ones but in the first line we are doing
t.OtherTxs = make([][]byte, 0, len(allTxs))which mean all other txs will be cleared
|
|
||
| // UpdateUsedBytes updates the used bytes field. This returns an error if the num used bytes | ||
| // exceeds the max byte limit. | ||
| func (t *PrepareProposalTxs) UpdateUsedBytes( |
There was a problem hiding this comment.
it seems this should be private, as using this without corresponding transactions operations would leave PrepareProposalTxs struct in bad state
github-actions bot
pushed a commit
that referenced
this pull request
Mar 3, 2025
Closes babylonlabs-io/pm#250. In the PR, PrepareProposal first adds the injected checkpoint tx and then add normal txs by order until byte limit is hit (cherry picked from commit 638d5ef)
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
KonradStaniec
pushed a commit
that referenced
this pull request
Mar 3, 2025
# Backport This will backport the following commits from `main` to `release/v1.x`: - [fix: Proposal vote extensions' byte limit (#585)](#585) <!--- Backport version: 9.5.1 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) Co-authored-by: Cirrus Gai <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes https://github.com/babylonlabs-io/pm/issues/250. In the PR, PrepareProposal first adds the injected checkpoint tx and then add normal txs by order until byte limit is hit