Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement hook_update_last_removed() #1

Open
wants to merge 3 commits into
base: 1.x-2.x
Choose a base branch
from
+12 −2
Open

Implement hook_update_last_removed() #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
87c3e6d
Implement hook_update_last_removed(), which is the second part of cre…
sillygwailo Feb 13, 2015
4bfb014
There's no more hook_page_alter() in Backdrop, so use hook_init() ins…
sillygwailo Feb 18, 2015
6410cdf
Fix a few instances of broken configuration.
sillygwailo Feb 18, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions googleanalytics.install
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,3 +111,10 @@ function googleanalytics_update_1001() {
update_variable_del('googleanalytics_codesnippet_after');
update_variable_del('googleanalytics_debug');
}

/**
* Implements hook_update_last_removed().
*/
function googleanalytics_update_last_removed() {
return 7205;
}
7 changes: 5 additions & 2 deletions googleanalytics.module
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,9 +81,9 @@ function googleanalytics_menu() {
}

/**
* Implements hook_page_alter() to insert JavaScript to the appropriate scope/region of the page.
* Implements hook_init() to insert JavaScript to the appropriate scope/region of the page.
*/
function googleanalytics_page_alter(&$page) {
function googleanalytics_init() {
global $user;
$config = config('googleanalytics.settings');

Expand Down Expand Up @@ -428,6 +428,7 @@ function googleanalytics_user_presave(&$edit, $account, $category) {
* Implements hook_cron().
*/
function googleanalytics_cron() {
$config = config('googleanalytics.settings');
// Regenerate the tracking code file every day.
if (REQUEST_TIME - $config->get('last_cache') >= 86400 && $config->get('cache')) {
_googleanalytics_cache('http://www.google-analytics.com/analytics.js', TRUE);
Expand Down Expand Up @@ -547,6 +548,7 @@ function googleanalytics_clear_js_cache() {
function _googleanalytics_visibility_user($account) {

$enabled = FALSE;
$config = config('googleanalytics.settings');

// Is current user a member of a role that should be tracked?
if (_googleanalytics_visibility_header($account) && _googleanalytics_visibility_roles($account)) {
Expand Down Expand Up @@ -575,6 +577,7 @@ function _googleanalytics_visibility_user($account) {
*/
function _googleanalytics_visibility_roles($account) {

$config = config('googleanalytics.settings');
$visibility = $config->get('visibility_roles');
$enabled = $visibility;
$roles = $config->get('roles');
Expand Down