-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Insert appears not to work with CKEditor 5 #22
Comments
This also applies to TinyMCE - the error displayed in console is the same.
|
I can confirm that the issue is not present if you switch back to jQuery 1 (Legacy), so at least there's a workaround, for now. |
@jromine here's a PR that addresses the jQuery compatibility problem. More info in the documentation: https://api.jquery.com/size/ This does not address the CKEditor5 compatibility problem, which seem a lot trickier, but at least with that small change the module works with jQuery 3 and TinyMCE. 😉 |
Thanks @indigoxela, I merged your bugfix PR as it seemed only beneficial. I'll take a look at making this work with CKE5. Wish me luck. 😅 |
I was successful getting this working, but it's not super-clean. I filed a PR at #24. The problem I encountered is that we need to track which CKEditor instance is the "active" one. TinyMCE politely provides In the mean time, my PR works fine, but it might not work if you're on a particularly slow connection or computer, as it's just guessing when the loading is complete (2 seconds) rather than receiving a |
When trying to insert a link to a document attached to a node (a pdf for example) into the Body field (CKEditor 5), it doesn't work.
Instead this message is displayed in the developer console of Google Chrome:
I tested this with a fresh build in tugboat, but had experienced it on several recently-updated sites (to Backdrop 1.28.2).
The text was updated successfully, but these errors were encountered: