Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

πŸš€ 날씨 api λ¦¬νŒ©ν† λ§ 및 ν…ŒμŠ€νŠΈ μ½”λ“œ μž‘μ„± #52

Merged
merged 57 commits into from
Jan 8, 2024
Merged

πŸš€ 날씨 api λ¦¬νŒ©ν† λ§ 및 ν…ŒμŠ€νŠΈ μ½”λ“œ μž‘μ„± #52

merged 57 commits into from
Jan 8, 2024

Conversation

Sehee-Lee-01
Copy link
Member

@Sehee-Lee-01 Sehee-Lee-01 commented Jan 6, 2024 •
edited
Loading

βœ… μš”κ΅¬μ‚¬ν•­

  • 날씨 κ΄€λ ¨ κΈ°λŠ₯ ꡬ쑰 λž˜νŒ©ν† λ§
  • 날씨 κ΄€λ ¨ 클래슀 ν…ŒμŠ€νŠΈ μ½”λ“œ μž‘μ„±
  • κΈ°μ‘΄ μ½”λ“œ 쀑 μŠ€νƒ€μΌ 체크 κ±Έλ¦¬λŠ” 것 μˆ˜μ • 및 체크 μŠ€νƒ€μΌ 파일 관리 μ„€μ •
    • μ•žμœΌλ‘œλŠ” μŠ€νƒ€μΌμ΄ μ΄μƒν•΄μ„œ μž¬μ„€μ •ν•  λ•Œ 기본적으둜 .idea/codeStyles/Project.xml 파일둜 μ„€μ •ν•΄μ£Όμ‹œλ©΄ λ©λ‹ˆλ‹€!

πŸš€ μ£Όμš” 변경사항

  • 날씨 κ΄€λ ¨ κΈ°λŠ₯ ꡬ쑰 λž˜νŒ©ν† λ§
  • 날씨 κ΄€λ ¨ 클래슀 ν…ŒμŠ€νŠΈ μ½”λ“œ μž‘μ„±
  • κΈ°μ‘΄ μ½”λ“œ 쀑 μŠ€νƒ€μΌ 체크 κ±Έλ¦¬λŠ” 것 μˆ˜μ •

πŸ’‘ 기타사항

  • κ²Œμ‹œκΈ€κ³Ό ν•¨κ»˜ μ €μž₯λ˜λŠ” 날씨관련 정보 λ¦¬νŒ©ν† λ§ ν•„μš”
  • 기온 기반 κ²Œμ‹œκΈ€ 뢈러였기 κΈ°λŠ₯ κ΅¬ν˜„ κ³ λ €

@Sehee-Lee-01
refactor: openfeign configλ₯Ό μ •μ˜ν•˜μ—¬ 관심사 뢄리
221bee5
@Sehee-Lee-01
refactor: openfeign yaml μ„€μ • μˆ˜μ •
c46b8f2
@Sehee-Lee-01
fix: κΈ°λ³Έ μœ„μΉ˜ μ„œμšΈ 쀑ꡬ μœ„μΉ˜λ‘œ μˆ˜μ •
e7ef11a
@Sehee-Lee-01
refactor: 응닡을 Json 자체둜 받도둝 λ³€κ²½
9962fe5
@Sehee-Lee-01
feat: api μš”μ²­ 응닡 μƒνƒœλ₯Ό 확인할 수 μžˆλŠ” header 클래슀 μ •μ˜
7da0e06
@Sehee-Lee-01
feat: api μš”μ²­ μ‘λ‹΅μ—μ„œ μ—λŸ¬κ°€ λ°œμƒν–ˆλŠ”μ§€ ν™•μΈν•˜λŠ” 클래슀 μ •μ˜
361a502
@Sehee-Lee-01
refactor: api μš”μ²­ 응닡 μ„±κ³΅μ‹œμ—λ§Œ μƒμ„±λ˜λŠ” ν΄λž˜μŠ€λΌλŠ” 의미λ₯Ό 담도둝 λͺ…μΉ­ λ³€κ²½(ForecastSuccessRes…
0c1021f 
…ultBody)
@Sehee-Lee-01
feat: api μš”μ²­ 응닡 ν›„ 처리 둜직 κ΅¬ν˜„
c4f47b5
@Sehee-Lee-01
feat: 날씨 μš”μ²­ νŒŒλΌλ―Έν„° validation μΆ”κ°€
e176aa3
@Sehee-Lee-01
feat: 날씨 μš”μ²­μ— λŒ€ν•œ μ˜ˆμ™Έλ₯Ό κ΄€λ¦¬ν•˜λŠ” RestControllerAdvice μ •μ˜
576bbdb
@Sehee-Lee-01
feat: μš”μ²­ νŒŒλΌλ―Έν„°μ— λŒ€ν•œ μ „μ—­ μ˜ˆμ™Έ 처리 둜직 μΆ”κ°€
6492c89
@Sehee-Lee-01
refactor: 기상청 api 기타 μ—λŸ¬ 처리 λ©”μ‹œμ§€ μΊ‘μŠν™” 및 μ—λŸ¬ 처리 둜직 μˆ˜μ •
cb21180
@Sehee-Lee-01
refactor: 날씨 컨트둀러 μ–΄λ“œλ°”μ΄μŠ€ λ©”μ„œλ“œλͺ… λ³€κ²½ 및 λ‘œκΉ…
249e147
@Sehee-Lee-01
refactor: jacoco 날씨 κ΄€λ ¨ test μ œμ™Έ λ‚΄μš© μ‚­μ œ
17018bb
@Sehee-Lee-01
refactor: ForecastResultHeader에 JsonDeserializer μ„€μ • ν›„ νŒ¨ν‚€μ§€ 이동
3dc5f46
@Sehee-Lee-01
refactor: ν˜„μž¬ 날씨 μ‘λ‹΅μ—μ„œ κΈ°ν›„ ν˜•νƒœ, ν•˜λŠ˜ μƒνƒœ 슀트링 κ°’μœΌλ‘œ 확인할 수 μžˆλ„λ‘ λ³€κ²½
3a555d2
@Sehee-Lee-01
enhance: κ°•μˆ˜ν˜•νƒœ νƒ€μž… μΆ”κ°€
4e5176f
@Sehee-Lee-01
refactor: 날씨 κ΄€λ ¨ 클래슀 νŒ¨ν‚€μ§€ ꡬ쑰 μž¬κ΅¬μ„±
5c34ed0
@Sehee-Lee-01
fix: κ°•μˆ˜ ν˜•νƒœ μΆ”κ°€ ν›„ μ‹€νŒ¨λ˜λŠ” ν…ŒμŠ€νŠΈ μ½”λ“œ μ„±κ³΅ν•˜λ„λ‘ μˆ˜μ •
777d4de
@Sehee-Lee-01
fix: μ˜ˆμ™Έ μ•ˆλ˜μ Έμ§€λŠ” 버그 μˆ˜μ • 및 λ˜μ§€λŠ” μ˜ˆμ™Έ μˆ˜μ •
fe7b301
@Sehee-Lee-01
feat: 컨트둀러 νŒŒλΌλ―Έν„° 였λ₯˜ μž‘λŠ” ν•Έλ“€λŸ¬ μ •μ˜ 및 μ€„λ°”κΏˆ μˆ˜μ •
281c446
@Sehee-Lee-01
feat: WeatherControllerAdviceμ—μ„œ μ²˜λ¦¬ν•˜λŠ” μ˜ˆμ™Έ μˆ˜μ •
c9cdb9a
@Sehee-Lee-01
feat: WeatherController ν…ŒμŠ€νŠΈ μ½”λ“œ μž‘μ„±
55d4759
@Sehee-Lee-01
fix: λΆˆν•„μš”ν•œ 파일 μ‚­μ œ
8bb0519
@Sehee-Lee-01
refactor: mockMvc μ μš©ν•΄λ³΄κΈ°
d548195
@Sehee-Lee-01
refactor: ForecastResultItem μž¬κ΅¬μ„± 및 dto 클래슀 ꡬ쑰 μž¬κ΅¬μ„±
f998ec6
@Sehee-Lee-01
refactor: Objects.equals μ΄μš©ν•˜λ„λ‘ μˆ˜μ •
6bfa2a0
@Sehee-Lee-01
test: ForecastCategory ν…ŒμŠ€νŠΈ μ½”λ“œ μž‘μ„±
79f3ed9
@Sehee-Lee-01
test: ForecastResultErrorManager ν…ŒμŠ€νŠΈ μ½”λ“œ μž‘μ„±
b0b6e8e
@Sehee-Lee-01
test: BaseDateTimeCalculator ν…ŒμŠ€νŠΈ μ½”λ“œ μž‘μ„±
717a735
@backendoori backendoori deleted a comment from github-actions bot Jan 7, 2024
@backendoori backendoori deleted a comment from github-actions bot Jan 7, 2024
@backendoori backendoori deleted a comment from github-actions bot Jan 7, 2024
@backendoori backendoori deleted a comment from github-actions bot Jan 8, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 8, 2024

πŸ“‘ Jacoco ν…ŒμŠ€νŠΈ κ²°κ³Ό

Overall Project 96.59% -0.5% 🍏
Files changed 97.5% 🍏

File Coverage
Post.java 100% 🍏
ForecastCategory.java 100% 🍏
OotwApplication.java 100% 🍏
WeatherService.java 100% 🍏
ForecastResultItem.java 100% 🍏
ForecastResultHeader.java 100% 🍏
ForecastSuccessResultBody.java 100% 🍏
BaseDateTime.java 100% 🍏
OpenFeignConfig.java 100% 🍏
ForecastSuccessResultBodyDeserializer.java 100% 🍏
ForecastResultItemSerializer.java 100% 🍏
ForecastResultHeaderDeserializer.java 100% 🍏
WeatherController.java 100% 🍏
PostSaveResponse.java 100% 🍏
PostSaveRequest.java 100% 🍏
PostReadResponse.java 100% 🍏
WeatherDto.java 100% 🍏
WeatherResponse.java 100% 🍏
ForecastProperties.java 100% 🍏
Weather.java 100% 🍏
SkyType.java 100% 🍏
Temperature.java 100% 🍏
PtyType.java 100% 🍏
ForecastResultErrorManager.java 93.55% -6.45% 🍏
BaseDateTimeCalculator.java 92.86% 🍏
ForecastApiClient.java 86.36% -13.64% 🍏
MiniOImageServiceImpl.java 84.27% 🍏
GlobalControllerAdvice.java 76.12% 🍏

ASak1104
ASak1104 reviewed Jan 8, 2024
View reviewed changes
Copy link
Collaborator

@ASak1104 ASak1104 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

주말 λ™μ•ˆ 고생 λ§ŽμœΌμ…¨μŠ΅λ‹ˆλ‹€!
μ½”λ“œλ§Œ 봀을 λ•ŒλŠ” μ–΄λ–€ λΆ€λΆ„μ—μ„œ κ³ λ―Όν•˜μ…¨λŠ”μ§€ λͺ¨λ‘ μ•ŒκΈ°κ°€ 쉽지 μ•Šλ„€μš”
같이 μ΄μ•ΌκΈ°ν•΄λ³΄λ©΄μ„œ μ •λ¦¬ν•΄λ΄μš”

src/main/java/com/backendoori/ootw/config/OpenFeignConfig.java Outdated
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

μ΄λ ‡κ²Œ λΆ„λ¦¬ν•˜λŠ” 방식 정말 μ’‹λ„€μš” πŸ‘

src/main/java/com/backendoori/ootw/common/image/MiniOImageServiceImpl.java Outdated Show resolved Hide resolved
src/main/java/com/backendoori/ootw/weather/controller/WeatherController.java Outdated Show resolved Hide resolved
src/main/java/com/backendoori/ootw/weather/dto/forecast/ForecastResultHeader.java Outdated Show resolved Hide resolved
src/main/java/com/backendoori/ootw/weather/util/client/ForecastApiClient.java Outdated Show resolved Hide resolved
src/test/java/com/backendoori/ootw/weather/domain/SkyTypeTest.java Outdated Show resolved Hide resolved
src/test/java/com/backendoori/ootw/weather/exception/ForecastResultErrorManagerTest.java Outdated Show resolved Hide resolved
src/test/java/com/backendoori/ootw/weather/util/BaseDateTimeCalculatorTest.java Show resolved Hide resolved
src/test/java/com/backendoori/ootw/weather/util/client/ForecastApiClientTest.java Outdated Show resolved Hide resolved
src/test/java/com/backendoori/ootw/weather/util/client/ForecastApiClientTest.java Outdated Show resolved Hide resolved
@Sehee-Lee-01
refactor: ForecastApiClient μƒμ„±μž μ ‘κ·Όμ œν•œμž μ‚­μ œ
947a8c2
@Sehee-Lee-01
refactor: static final 톡일
1b23d9e
@Sehee-Lee-01
refactor: given when then λͺ…μ‹œ
8a58f27
@Sehee-Lee-01
refactor: νŒ¨ν‚€μ§€ μž¬κ΅¬μ„±
55d27c5
@Sehee-Lee-01
refactor: TestInstance(Lifecycle.PER_CLASS) λΆˆν•„μš”ν•œ 클래슀 ν•΄μ œ
c1204b3
@Sehee-Lee-01
refactor: MiniOImageServiceImpl κ°œν–‰ μˆ˜μ •
6e50102
@Sehee-Lee-01
refactor: νŒŒλΌλ―Έν„° λ””ν΄νŠΈ κ°’ μ‚­μ œ
878a8b0
@Sehee-Lee-01
refactor: @WithMockUser 클래슀 λ‹¨μœ„μ— 뢙이고 λ³€μˆ˜ μœ„μΉ˜ μž¬μ„€μ •
9d22687
@Sehee-Lee-01
refactor: @testinstance(Lifecycle.PER_CLASS) λΆˆν•„μš”ν•œ 클래슀 μˆ˜μ •
e0767e6
@Sehee-Lee-01
refactor: @testinstance(Lifecycle.PER_CLASS) λΆˆν•„μš”ν•œ 클래슀 μˆ˜μ •
9e4a2c8
@Sehee-Lee-01
merge: conflict ν•΄κ²° ν›„ feature둜 merge 진행
7444dbc 
- μ• ν”Œλ¦¬μΌ€μ΄μ…˜ μ‹€ν–‰ 정상
- ν…ŒμŠ€νŠΈ μ‹€ν–‰ 정상
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 8, 2024

πŸ“‘ Jacoco ν…ŒμŠ€νŠΈ κ²°κ³Ό

Overall Project 96.48% -0.46% 🍏
Files changed 97.43% 🍏

File Coverage
Post.java 100% 🍏
ForecastCategory.java 100% 🍏
OotwApplication.java 100% 🍏
WeatherService.java 100% 🍏
BaseDateTime.java 100% 🍏
OpenFeignConfig.java 100% 🍏
ForecastResultItem.java 100% 🍏
ForecastSuccessResultBodyDeserializer.java 100% 🍏
ForecastSuccessResultBody.java 100% 🍏
ForecastResultItemSerializer.java 100% 🍏
ForecastResultHeader.java 100% 🍏
ForecastResultHeaderDeserializer.java 100% 🍏
WeatherController.java 100% 🍏
PostSaveResponse.java 100% 🍏
PostSaveRequest.java 100% 🍏
PostReadResponse.java 100% 🍏
WeatherDto.java 100% 🍏
WeatherResponse.java 100% 🍏
ForecastProperties.java 100% 🍏
Weather.java 100% 🍏
SkyType.java 100% 🍏
Temperature.java 100% 🍏
PtyType.java 100% 🍏
ForecastResultErrorManager.java 93.55% -6.45% 🍏
BaseDateTimeCalculator.java 92.86% 🍏
MiniOImageServiceImpl.java 88.24% 🍏
ForecastApiClient.java 86.36% -13.64% 🍏

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 8, 2024

πŸ“‘ Jacoco ν…ŒμŠ€νŠΈ κ²°κ³Ό

Overall Project 96.48% -0.46% 🍏
Files changed 97.52% 🍏

File Coverage
Post.java 100% 🍏
ForecastCategory.java 100% 🍏
OotwApplication.java 100% 🍏
WeatherService.java 100% 🍏
BaseDateTime.java 100% 🍏
OpenFeignConfig.java 100% 🍏
ForecastResultItem.java 100% 🍏
ForecastSuccessResultBodyDeserializer.java 100% 🍏
ForecastSuccessResultBody.java 100% 🍏
ForecastResultItemSerializer.java 100% 🍏
ForecastResultHeader.java 100% 🍏
ForecastResultHeaderDeserializer.java 100% 🍏
WeatherController.java 100% 🍏
PostSaveResponse.java 100% 🍏
PostSaveRequest.java 100% 🍏
PostReadResponse.java 100% 🍏
WeatherDto.java 100% 🍏
WeatherResponse.java 100% 🍏
ForecastProperties.java 100% 🍏
Weather.java 100% 🍏
SkyType.java 100% 🍏
Temperature.java 100% 🍏
PtyType.java 100% 🍏
ForecastResultErrorManager.java 93.55% -6.45% 🍏
ImageValidator.java 92.86% 🍏
BaseDateTimeCalculator.java 92.86% 🍏
MiniOImageServiceImpl.java 88.24% 🍏
ForecastApiClient.java 86.36% -13.64% 🍏

@shoeone96 shoeone96 merged commit 2e388d2 into feature Jan 8, 2024
1 check passed
@shoeone96 shoeone96 deleted the feature-current-forecast branch January 8, 2024 06:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shoeone96 shoeone96 shoeone96 approved these changes

@ASak1104 ASak1104 ASak1104 approved these changes

Assignees

@Sehee-Lee-01 Sehee-Lee-01

Labels
enhancement New feature or request refactoring code refactoring
Projects
outfit-of-the-weather
Status: Done
Milestone
Must Have μ„œλΉ„μŠ€ λ¦¬νŒ©ν† λ§
Development

Successfully merging this pull request may close these issues.
3 participants
@Sehee-Lee-01 @ASak1104 @shoeone96