Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

๐Ÿš€ ๊ฒŒ์‹œ๊ธ€ ์ €์žฅํ•  ๋•Œ ๋‚ ์”จ api๋กœ ๋‹น์ผ ์ตœ์ €/์ตœ๊ณ  ๊ธฐ์˜จ ๋ถˆ๋Ÿฌ์˜ค๊ธฐ #57

Merged
merged 27 commits into from
Jan 9, 2024

Conversation

Sehee-Lee-01
Copy link
Member

@Sehee-Lee-01 Sehee-Lee-01 commented Jan 9, 2024

โœ… ์š”๊ตฌ์‚ฌํ•ญ

  • ๊ฒŒ์‹œ๊ธ€ ์ €์žฅํ•  ๋•Œ ๋‚ ์”จ api๋กœ ๋‹น์ผ ์ตœ์ €/์ตœ๊ณ  ๊ธฐ์˜จ ๋ถˆ๋Ÿฌ์˜ค๊ธฐ ๊ธฐ๋Šฅ ๊ตฌํ˜„
    • ๊ฒŒ์‹œ๊ธ€์„ ์ €์žฅํ•  ๋•Œ ์„œ๋ฒ„ ๋‚ด๋ถ€์ ์œผ๋กœ ๋‚ ์”จ api๋ฅผ ์ด์šฉํ•ด ๋‹น์ผ์˜ ์ตœ์ €/์ตœ๊ณ  ๊ธฐ์˜จ์„ ๋ถˆ๋Ÿฌ์˜ค๊ณ  ๊ฒŒ์‹œ๊ธ€ ์ •๋ณด์™€ ํ•จ๊ป˜ ์ €์žฅํ•œ๋‹ค.
    • ๊ฒŒ์‹œ๊ธ€์„ ์กฐํšŒํ•  ๋•Œ ๊ฒŒ์‹œ๊ธ€์„ ์ €์žฅํ•œ ๋‹น์‹œ์˜ ์ตœ์ €/์ตœ๊ณ  ๊ธฐ์˜จ์„ ํ™•์ธํ•  ์ˆ˜ ์žˆ๋‹ค.
  • ์ผ๋ถ€ ํŒŒ์ผ ์Šคํƒ€์ผ ์ˆ˜์ •

๐Ÿš€ ์ฃผ์š” ๋ณ€๊ฒฝ์‚ฌํ•ญ

  • ๐Ÿšจ SQL ํŒŒ์ผ ์ •๋ณด๊ฐ€ ๋ฐ”๋€Œ์—ˆ์Šต๋‹ˆ๋‹ค! ์ปจํ…Œ์ด๋„ˆ๋ฅผ ๋‹ค์‹œ ๋„์›Œ์•ผํ•ฉ๋‹ˆ๋‹ค!
  • ๊ฒŒ์‹œ๊ธ€ ์ €์žฅํ•  ๋•Œ request body์— ๋‚ ์”จ๋ฅผ ๋ถˆ๋Ÿฌ์˜ฌ ์ขŒํ‘œ๊ฐ’์„ ํ•จ๊ป˜ ๋ณด๋‚ด์•ผํ•ฉ๋‹ˆ๋‹ค! -> postman์—์„œ ํ™•์ธํ•  ์ˆ˜ ์žˆ์Šต๋‹ˆ๋‹ค.
  • WeatherService์— ์˜ค๋Š˜์˜ ์ผ๊ต์ฐจ๋ฅผ ๋ถˆ๋Ÿฌ์˜ค๋Š” ๋ฉ”์„œ๋“œ(getCurrentTemperatureArrange) ์ถ”๊ฐ€
  • Weather, WeatherDTO๋ฅผ ์ €์žฅํ•˜๋Š” ์ •๋ณด์— ๋งž๊ฒŒ TemperatureArrange, TemperatureArrangeDto๋กœ ์ด๋ฆ„ ๋ณ€๊ฒฝ
  • ๋ณ€๊ฒฝ๋œ ๊ตฌ์กฐ์— ๋”ฐ๋ฅธ ํ…Œ์ŠคํŠธ ์ฝ”๋“œ ๋ฆฌํŒฉํ† ๋ง ๋ฐ ์ˆ˜์ •

๐Ÿ’ก ๊ธฐํƒ€์‚ฌํ•ญ

  • ์ปจํ…Œ์ด๋„ˆ ๋‹ค์‹œ ๋„์šฐ๊ธฐ!!!

- ์ด๋ฏธ ๊ฒ€์ฆ๋˜์–ด ์ƒ์„ฑ๋œ TemperatureArrange๋กœ๋ถ€ํ„ฐ ์ƒ์„ฑํ•˜๋Š” ๊ฒƒ์ด ๋Œ€๋ถ€๋ถ„
- ๋ณด๋‚ด๋Š” ์šฉ๋„์ด๊ธฐ ๋•Œ๋ฌธ์— ์š”์ฒญ์œผ๋กœ๋ถ€ํ„ฐ ๋ฐ›๋Š” ๊ฒƒ๋ณด๋‹ค ๊ฒ€์ฆ์„ ๋œ ์‹ ๊ฒฝ์จ๋„ ๋  ๊ฒƒ ๊ฐ™๋‹ค.
Copy link

github-actions bot commented Jan 9, 2024

๐Ÿ“‘ Jacoco ํ…Œ์ŠคํŠธ ๊ฒฐ๊ณผ

Overall Project 96.42% -0.48% ๐Ÿ
Files changed 97.27% ๐Ÿ

File Coverage
Post.java 100% ๐Ÿ
WeatherService.java 100% ๐Ÿ
ForecastResultItem.java 100% ๐Ÿ
WeatherController.java 100% ๐Ÿ
PostSaveResponse.java 100% ๐Ÿ
PostSaveRequest.java 100% ๐Ÿ
PostReadResponse.java 100% ๐Ÿ
WeatherResponse.java 100% ๐Ÿ
TemperatureArrangeDto.java 100% ๐Ÿ
PostService.java 100% ๐Ÿ
PostValidator.java 95.83% -4.17% ๐Ÿ
BaseDateTimeCalculator.java 95.71% ๐Ÿ
ForecastApiClient.java 95.08% -3.28% ๐Ÿ
ForecastResultErrorManager.java 93.55% ๐Ÿ
TemperatureArrange.java 90.32% -9.68% ๐Ÿ

@shoeone96 shoeone96 merged commit 3181852 into main Jan 9, 2024
1 check passed
@shoeone96 shoeone96 deleted the refactor-min-max-weather branch January 9, 2024 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request refactoring code refactoring
Projects
Status: Done
3 participants