Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Explicitly set target linker language for compat CMakeLists.txt #33

Merged
merged 2 commits into from
Mar 31, 2023
Merged

Explicitly set target linker language for compat CMakeLists.txt #33

merged 2 commits into from
Mar 31, 2023

Conversation

KrzaQ
Copy link
Contributor

@KrzaQ KrzaQ commented Feb 25, 2023

This fixes compatibility with CMake's Ninja generator

@janisozaur @KrzaQ
Explicitly set target linker language for compat CMakeLists.txt
a138af5 
This fixes compatibility with CMake's Ninja generator
@KrzaQ KrzaQ force-pushed the fix-linux-ninja-build branch 9 times, most recently from 875fed3 to 91f2f18 Compare February 25, 2023 21:14
@janisozaur
Copy link
Contributor

I've submitted #34 as well

@janisozaur
Copy link
Contributor

And removed the other commit from #29, it does pass with current CI setup

@KrzaQ KrzaQ force-pushed the fix-linux-ninja-build branch 7 times, most recently from ec17471 to bca9622 Compare February 26, 2023 04:11
@janisozaur
Copy link
Contributor

any updates?

@KrzaQ
Copy link
Contributor Author

KrzaQ commented Mar 15, 2023

Hi, sorry for the delay! I expect to work on this (and hopefully be done) towards the end of this week.

@KrzaQ KrzaQ force-pushed the fix-linux-ninja-build branch 6 times, most recently from 7e798dc to 7ab634b Compare March 29, 2023 04:48
@KrzaQ
Copy link
Contributor Author

KrzaQ commented Mar 29, 2023

It looks like I finally got the tests working. I'll proceed with this today

@KrzaQ KrzaQ force-pushed the fix-linux-ninja-build branch from 7ab634b to 310d064 Compare March 30, 2023 04:01
@KrzaQ KrzaQ requested a review from konraddysput March 30, 2023 04:14
@KrzaQ KrzaQ self-assigned this Mar 30, 2023
@janisozaur
Copy link
Contributor

It seems you will have to update the required jobs' names for this to be merge-able.

@KrzaQ KrzaQ merged commit 310d064 into backtrace Mar 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@konraddysput konraddysput konraddysput approved these changes

Assignees

@KrzaQ KrzaQ

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@KrzaQ @janisozaur @konraddysput