SAO improvements #157
Closed
SAO improvements #157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
renzenicolai
commented
Sep 3, 2023
| uint8_t magic[4]; | ||
| uint8_t name_length; | ||
| uint8_t driver_name_length; | ||
| uint8_t driver_data_length; | ||
| uint8_t number_of_extra_drivers; | ||
| } sao_binary_header_t; | ||
|
|
||
| typedef struct __attribute__((__packed__)) _sao_binary_extra_driver { |
There was a problem hiding this comment.
Please leave these _name markers on the typedefs, this is the name of the struct and helps with warnings and debugging.
| // Basic IO driver | ||
|
|
||
|
|
||
| /* ==== Basic IO driver ==== */ |
There was a problem hiding this comment.
Please do not use /* */ for single line comments, revert this back to "// comment" styling
There was a problem hiding this comment.
We should really enforce this using a formatter tool, I will add that to my to-do list.
| void dump_eeprom_contents(); | ||
|
|
||
| esp_err_t sao_identify(SAO* sao); | ||
| esp_err_t sao_write_raw(size_t offset, uint8_t* buffer, size_t buffer_length); | ||
| esp_err_t sao_format(const char* name, const char* driver, const uint8_t* driver_data, uint8_t driver_data_length, const char* driver2, | ||
| esp_err_t sao_format_old(const char* name, const char* driver, const uint8_t* driver_data, uint8_t driver_data_length, const char* driver2, |
There was a problem hiding this comment.
No need to keep old functions, either your new function covers all usecases or this function is not old.
There was a problem hiding this comment.
Why does the sdk config need to be changed?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.