Addressed review comments

badoo · Jun 3, 2024 · bf68e74 · bf68e74
1 parent a35e4d3
commit bf68e74
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/sample-android-app/build.gradle b/sample-android-app/build.gradle
@@ -5,12 +5,12 @@ plugins {
 
 android {
     namespace "com.badoo.reaktive.sample.android"
-    compileSdk 33
+    compileSdk 34
 
     defaultConfig {
         applicationId 'com.badoo.reaktive.sample.android'
         minSdkVersion 15
-        targetSdkVersion 33
+        targetSdkVersion 34
         versionCode 1
         versionName '1.0'
     }

diff --git a/sample-mpp-module/build.gradle b/sample-mpp-module/build.gradle
@@ -8,6 +8,7 @@ android {
 }
 
 kotlin {
+    // Only export the framework under an Xcode build as part of the pre-build step script
     if (System.getenv().keySet().contains("XCODE_VERSION_MAJOR")) {
         def configureFrameworks = { target ->
             target.binaries {